You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/09 07:27:07 UTC

[GitHub] [arrow-rs] ritchie46 commented on pull request #269: Aligned vec

ritchie46 commented on pull request #269:
URL: https://github.com/apache/arrow-rs/pull/269#issuecomment-835725464


   Hi @jorgecarleitao,
   
   I don't mean to build a shadow API. This came up as a point of discussion with @alamb  a while ago. This was used in `polars` and we discussed that it would maybe was a better fit in the `arrow` library. I believe that at that point the mutable buffer API still only worked with bytes, so perhaps our discussion is already outdated.
   
   The rationale for me was that I like the `Vec<T>` API, because it is familiar, and performant. Maybe the performant reasons are outdated as well now that the `mutablebuffer` from `arrow2` is typed? In that case, can we replace this PR with the typed mutablebuffer proposal? :wink: 
   
   One thing that would maybe be interesting for a copy of `Vec<T>`'s API is that we later could easily switch to a  custom allocator on `Vec<T>`, once that's stable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org