You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/23 03:08:54 UTC
[GitHub] [spark] anchovYu opened a new pull request #35616: [SPARK-38295][SQL][Tests] Fix ArithmeticExpressionSuite under ANSI mode
anchovYu opened a new pull request #35616:
URL: https://github.com/apache/spark/pull/35616
### What changes were proposed in this pull request?
Fix all the failure test cases (about 8 in total) in org.apache.spark.sql.catalyst.expressions.ArithmeticExpressionSuite.
Most of them are divided by zero. For these test cases, wrap with ANSI as false. Also add exact same test input wrapping with ANSI true, but set the expectation to the exceptions of divide by zero.
### Why are the changes needed?
To set up a new GA job to run tests with ANSI mode before 3.3.0 release.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Test locally with both ANSI on and off, both passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #35616: [SPARK-38295][SQL][Tests] Fix ArithmeticExpressionSuite under ANSI mode
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #35616:
URL: https://github.com/apache/spark/pull/35616#issuecomment-1048681452
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #35616: [SPARK-38295][SQL][Tests] Fix ArithmeticExpressionSuite under ANSI mode
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #35616:
URL: https://github.com/apache/spark/pull/35616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35616: [SPARK-38295][SQL][Tests] Fix ArithmeticExpressionSuite under ANSI mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35616:
URL: https://github.com/apache/spark/pull/35616#issuecomment-1048443690
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org