You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/01/19 07:36:26 UTC

[GitHub] [cloudstack] weizhouapache opened a new issue #5877: vmware: disk controller "pvscsi" is not applied on scsiX.virtualDev

weizhouapache opened a new issue #5877:
URL: https://github.com/apache/cloudstack/issues/5877


   in vmx file, the scsiX.virtualDev is not changed to "pvscsi" when root and data disk controller are set to "pvscsi"
   
   ##### ISSUE TYPE
   <!-- Pick one below and delete the rest -->
    * Bug Report
   
   
   ##### COMPONENT NAME
   <!--
   Categorize the issue, e.g. API, VR, VPN, UI, etc.
   -->
   ~~~
   vmware
   ~~~
   
   ##### CLOUDSTACK VERSION
   <!--
   New line separated list of affected versions, commit ID for issues on main branch.
   -->
   
   ~~~
   4.16
   ~~~
   
   ##### CONFIGURATION
   <!--
   Information about the configuration if relevant, e.g. basic network, advanced networking, etc.  N/A otherwise
   -->
   
   
   ##### OS / ENVIRONMENT
   <!--
   Information about the environment if relevant, N/A otherwise
   -->
   
   
   ##### SUMMARY
   <!-- Explain the problem/feature briefly -->
   
   By default, the scsiX.virtualDev is "lsilogic".
   when I set root and data disk controller to "pvscsi", I expect that the scsiX.virtualDev is changed to "pvscsi".
   
   ##### STEPS TO REPRODUCE
   <!--
   For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
   
   For new features, show how the feature would be used.
   -->
   
   <!-- Paste example playbooks or commands between quotes below -->
   ~~~
   1. create a vm and start it
   
   the vm has config in vmx file
   
   # grep scsi /vmfs/volumes/85f59f3e-422b762e/i-2-4-VM/i-2-4-VM.vmx
   scsi0.virtualDev = "lsilogic"
   scsi0.present = "TRUE"
   scsi1.virtualDev = "lsilogic"
   scsi1.present = "TRUE"
   scsi2.virtualDev = "lsilogic"
   scsi2.present = "TRUE"
   scsi3.virtualDev = "lsilogic"
   scsi3.present = "TRUE"
   scsi0.pciSlotNumber = "16"
   scsi1.pciSlotNumber = "32"
   scsi2.pciSlotNumber = "33"
   scsi3.pciSlotNumber = "34"
   
   2. stop the vm, and change  vm setting
   
   rootDiskController=pvscsi
   dataDiskController=pvscsi
   
   3. start the vm
   
   
   # grep scsi /vmfs/volumes/85f59f3e-422b762e/i-2-4-VM/i-2-4-VM.vmx
   scsi0.virtualDev = "lsilogic"
   scsi0.present = "TRUE"
   scsi1.virtualDev = "lsilogic"
   scsi1.present = "TRUE"
   scsi2.virtualDev = "lsilogic"
   scsi2.present = "TRUE"
   scsi3.virtualDev = "lsilogic"
   scsi3.present = "TRUE"
   scsi0.pciSlotNumber = "16"
   scsi1.pciSlotNumber = "32"
   scsi2.pciSlotNumber = "33"
   scsi3.pciSlotNumber = "34"
   scsi0:0.deviceType = "scsi-hardDisk"
   scsi0:0.fileName = "ROOT-4.vmdk"
   scsi0:0.present = "TRUE"
   dataDiskController = "pvscsi"
   rootDiskController = "pvscsi"
   scsi0:0.redo = ""
   
   ~~~
   
   <!-- You can also paste gist.github.com links for larger files -->
   
   ##### EXPECTED RESULTS
   <!-- What did you expect to happen when running the steps above? -->
   
   ~~~
   
   scsi0.virtualDev = "pvscsi"
   scsi0.present = "TRUE"
   scsi1.virtualDev = "pvscsi"
   scsi1.present = "TRUE"
   scsi2.virtualDev = "pvscsi"
   scsi2.present = "TRUE"
   scsi3.virtualDev = "pvscsi"
   scsi3.present = "TRUE"
   
   ~~~
   
   ##### ACTUAL RESULTS
   <!-- What actually happened? -->
   
   <!-- Paste verbatim command output between quotes below -->
   ~~~
   scsi0.virtualDev = "lsilogic"
   scsi0.present = "TRUE"
   scsi1.virtualDev = "lsilogic"
   scsi1.present = "TRUE"
   scsi2.virtualDev = "lsilogic"
   scsi2.present = "TRUE"
   scsi3.virtualDev = "lsilogic"
   scsi3.present = "TRUE"
   ~~~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rohityadavcloud commented on issue #5877: vmware: disk controller "pvscsi" is not applied on scsiX.virtualDev

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on issue #5877:
URL: https://github.com/apache/cloudstack/issues/5877#issuecomment-1016189406


   @weizhouapache @sureshanaparti let's check VMwareResourceBase, it might be a historic limitation that under some circumstance controllers are not always added as configured in the template/disk controller properties.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache edited a comment on issue #5877: vmware: disk controller "pvscsi" is not applied on scsiX.virtualDev

Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on issue #5877:
URL: https://github.com/apache/cloudstack/issues/5877#issuecomment-1017629746


   @sureshanaparti @rohityadavcloud 
   no, I did not notice such logs.
   I have investigated the issue and found that cloudstack does not update existing disk.
   
   https://github.com/apache/cloudstack/blob/7f000f50164b2c47a726518f5752d7bdae68f057/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java#L1776-L1793
   
   the workaround is
   (1) create a vm, but not start it
   (2) update vm settings, set root and data disk controller to 'pvscsi'
   (3) start the vm
   Then the vm will have correct SCSI controller.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland closed issue #5877: vmware: disk controller "pvscsi" is not applied on scsiX.virtualDev

Posted by GitBox <gi...@apache.org>.
DaanHoogland closed issue #5877:
URL: https://github.com/apache/cloudstack/issues/5877


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on issue #5877: vmware: disk controller "pvscsi" is not applied on scsiX.virtualDev

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on issue #5877:
URL: https://github.com/apache/cloudstack/issues/5877#issuecomment-1017195578


   > @weizhouapache @sureshanaparti let's check VMwareResourceBase, it might be a historic limitation that under some circumstance controllers are not always added as configured in the template/disk controller properties.
   
   @rohityadavcloud Correct, pvscsi controller is bypassed to use lsilogic controller when the support for different scsi controller types was introduced. It seems the vmdk property "ddb.adapterType" is not properly set for pvscsi controller, and also it is not supported for virtual hardware version < 7. May be, we have to re-visit it and check whether the limitation still exists or not.
   
   https://github.com/apache/cloudstack/blob/7f000f50164b2c47a726518f5752d7bdae68f057/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VmdkAdapterType.java#L30-L31
   
   https://github.com/apache/cloudstack/blob/7f000f50164b2c47a726518f5752d7bdae68f057/vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java#L708-L711


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache edited a comment on issue #5877: vmware: disk controller "pvscsi" is not applied on scsiX.virtualDev

Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on issue #5877:
URL: https://github.com/apache/cloudstack/issues/5877#issuecomment-1017629746


   @sureshanaparti @rohityadavcloud 
   no, I did not notice such logs.
   I have investigated the issue and found that cloudstack does not update existing disk.
   
   https://github.com/apache/cloudstack/blob/7f000f50164b2c47a726518f5752d7bdae68f057/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java#L1776-L1792
   
   the workaround is
   (1) create a vm, but not start it
   (2) update vm settings, set root and data disk controller to 'pvscsi'
   (3) start the vm
   Then the vm will have correct SCSI controller.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on issue #5877: vmware: disk controller "pvscsi" is not applied on scsiX.virtualDev

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #5877:
URL: https://github.com/apache/cloudstack/issues/5877#issuecomment-1034931173


   fixed in #5910


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] sureshanaparti commented on issue #5877: vmware: disk controller "pvscsi" is not applied on scsiX.virtualDev

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on issue #5877:
URL: https://github.com/apache/cloudstack/issues/5877#issuecomment-1017197128


   Hi @weizhouapache Have you noticed any logs indicating 'pvscsi' controller is bypassed to use 'lsilogic' controller?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on issue #5877: vmware: disk controller "pvscsi" is not applied on scsiX.virtualDev

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #5877:
URL: https://github.com/apache/cloudstack/issues/5877#issuecomment-1017629746


   @sureshanaparti @rohityadavcloud 
   no, I did not notice such logs.
   I have investigated the issue and found that cloudstack does not update existing disk.
   
   https://github.com/apache/cloudstack/blob/4.16.0.0/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java#L1808-L1817
   
   the workaround is
   (1) create a vm, but not start it
   (2) update vm settings, set root and data disk controller to 'pvscsi'
   (3) start the vm
   Then the vm will have correct SCSI controller.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org