You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2024/02/15 00:58:54 UTC

(superset) branch master updated: fix(docker): *-dev tags target right stage from Dockerfile (#27116)

This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 9514300da5 fix(docker): *-dev tags target right stage from Dockerfile (#27116)
9514300da5 is described below

commit 9514300da5e8aa0ef797f8a793b5d623f54048d8
Author: lodu <48...@users.noreply.github.com>
AuthorDate: Thu Feb 15 01:58:47 2024 +0100

    fix(docker): *-dev tags target right stage from Dockerfile (#27116)
---
 scripts/build_docker.py                  | 1 +
 tests/unit_tests/scripts/docker_build.py | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/build_docker.py b/scripts/build_docker.py
index 00023afc0a..13453b61f9 100755
--- a/scripts/build_docker.py
+++ b/scripts/build_docker.py
@@ -204,6 +204,7 @@ def get_docker_command(
         {cache_to_arg} \\
         {build_arg} \\
         {platform_arg} \\
+        {target_argument} \\
         --label sha={sha} \\
         --label target={build_target} \\
         --label build_trigger={build_context} \\
diff --git a/tests/unit_tests/scripts/docker_build.py b/tests/unit_tests/scripts/docker_build.py
index 1f3fd708f3..293f9447cb 100644
--- a/tests/unit_tests/scripts/docker_build.py
+++ b/tests/unit_tests/scripts/docker_build.py
@@ -256,7 +256,7 @@ def test_get_docker_tags(
             SHA,
             "push",
             "master",
-            ["--load", f"-t {REPO}:master-dev "],
+            ["--load", f"-t {REPO}:master-dev ", "--target dev"],
         ),
         # multi-platform
         (