You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kazuyukitanimura (via GitHub)" <gi...@apache.org> on 2023/09/28 21:57:09 UTC
[GitHub] [arrow-datafusion] kazuyukitanimura opened a new issue, #7689: Add Decimal128 support Ceil and Floor
kazuyukitanimura opened a new issue, #7689:
URL: https://github.com/apache/arrow-datafusion/issues/7689
### Is your feature request related to a problem or challenge?
`Ceil` and `Floor` in `math_expressions` support only `Float32` and `Float64` currently
### Describe the solution you'd like
Add `Decimal128` support `Ceil` and `Floor`
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Weijun-H commented on issue #7689: Add Decimal128 support to Ceil and Floor
Posted by "Weijun-H (via GitHub)" <gi...@apache.org>.
Weijun-H commented on issue #7689:
URL: https://github.com/apache/arrow-datafusion/issues/7689#issuecomment-1740248126
I think @viirya is correct.
```bash
❯ select ceil(arrow_cast(100000, 'Decimal128(38,1)'));
+---------------------+
| ceil(Int64(100000)) |
+---------------------+
| 100000.0 |
+---------------------+
1 row in set. Query took 0.004 seconds.
❯ select ceil(arrow_cast(100000.2, 'Decimal128(38,1)'));
+-------------------------+
| ceil(Float64(100000.2)) |
+-------------------------+
| 100001.0 |
+-------------------------+
1 row in set. Query took 0.004 seconds.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add Decimal128 support to Ceil and Floor [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #7689:
URL: https://github.com/apache/datafusion/issues/7689#issuecomment-3585498612
That sounds like the approach we'd need to take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add Decimal128 support to Ceil and Floor [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey closed issue #7689: Add Decimal128 support to Ceil and Floor
URL: https://github.com/apache/datafusion/issues/7689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add Decimal128 support to Ceil and Floor [datafusion]
Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal commented on issue #7689:
URL: https://github.com/apache/datafusion/issues/7689#issuecomment-3585347965
> > [@kazuyukitanimura](https://github.com/kazuyukitanimura) Is this still a requirement, I can take a look at it.
>
> Yes this would still be good to have
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add Decimal128 support to Ceil and Floor [datafusion]
Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal commented on issue #7689:
URL: https://github.com/apache/datafusion/issues/7689#issuecomment-3586000563
Great! Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add Decimal128 support to Ceil and Floor [datafusion]
Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal commented on issue #7689:
URL: https://github.com/apache/datafusion/issues/7689#issuecomment-3578991974
@kazuyukitanimura Is this still a requirement, I can take a look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
[GitHub] [arrow-datafusion] viirya commented on issue #7689: Add Decimal128 support Ceil and Floor
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on issue #7689:
URL: https://github.com/apache/arrow-datafusion/issues/7689#issuecomment-1740067455
I guess they supports it but a type coercion will happen on decimal input (to float type). Native support is not there though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add Decimal128 support to Ceil and Floor [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on issue #7689:
URL: https://github.com/apache/datafusion/issues/7689#issuecomment-3579775118
> [@kazuyukitanimura](https://github.com/kazuyukitanimura) Is this still a requirement, I can take a look at it.
Yes this would still be good to have
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org