You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2021/05/15 07:57:28 UTC

[GitHub] [karaf] PiotrKlimczak opened a new pull request #1377: KARAF-7152 Fixing Narayana object store initialisation

PiotrKlimczak opened a new pull request #1377:
URL: https://github.com/apache/karaf/pull/1377


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] PiotrKlimczak removed a comment on pull request #1377: KARAF-7152 Fixing Narayana object store initialisation

Posted by GitBox <gi...@apache.org>.
PiotrKlimczak removed a comment on pull request #1377:
URL: https://github.com/apache/karaf/pull/1377#issuecomment-841627975


   Pushed assertion fix which I hope should not be AIO dependant anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] PiotrKlimczak commented on pull request #1377: KARAF-7152 Fixing Narayana object store initialisation

Posted by GitBox <gi...@apache.org>.
PiotrKlimczak commented on pull request #1377:
URL: https://github.com/apache/karaf/pull/1377#issuecomment-841621610


   I am using MacOS and I have a feeling that due to missing AIO lib in MacOS, Narayana might display slightly different logs in Linux and other systems. Don't have any Linux around unfortunately.
   It is test passing on my machine every time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] PiotrKlimczak commented on pull request #1377: KARAF-7152 Fixing Narayana object store initialisation

Posted by GitBox <gi...@apache.org>.
PiotrKlimczak commented on pull request #1377:
URL: https://github.com/apache/karaf/pull/1377#issuecomment-841627975


   Pushed assertion fix which I hope should not be AIO dependant anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] jbonofre merged pull request #1377: KARAF-7152 Fixing Narayana object store initialisation

Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #1377:
URL: https://github.com/apache/karaf/pull/1377


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] grgrzybek commented on pull request #1377: KARAF-7152 Fixing Narayana object store initialisation

Posted by GitBox <gi...@apache.org>.
grgrzybek commented on pull request #1377:
URL: https://github.com/apache/karaf/pull/1377#issuecomment-906503138


   Mind that similar (the same?) issue was fixed in Pax Transx: ops4j/org.ops4j.pax.transx#50


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] jbonofre commented on pull request #1377: KARAF-7152 Fixing Narayana object store initialisation

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1377:
URL: https://github.com/apache/karaf/pull/1377#issuecomment-906499354


   Now that Karaf `main` branch is using Felix framework 6.0.5 I'm doing a new test on this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] PiotrKlimczak commented on pull request #1377: KARAF-7152 Fixing Narayana object store initialisation

Posted by GitBox <gi...@apache.org>.
PiotrKlimczak commented on pull request #1377:
URL: https://github.com/apache/karaf/pull/1377#issuecomment-841632759


   OK, I know what the problem is, unit test is hitting https://issues.apache.org/jira/browse/FELIX-6416 which I have reported separately, have it fixed locally but it is not yet merged.
   I have raised separately https://issues.apache.org/jira/browse/KARAF-7153 as blocker for this issue.
   Test will keep failing until https://issues.apache.org/jira/browse/KARAF-7153 is resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] jbonofre commented on pull request #1377: KARAF-7152 Fixing Narayana object store initialisation

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1377:
URL: https://github.com/apache/karaf/pull/1377#issuecomment-906555315


   I confirm that it works fine after rebase on `main`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] PiotrKlimczak edited a comment on pull request #1377: KARAF-7152 Fixing Narayana object store initialisation

Posted by GitBox <gi...@apache.org>.
PiotrKlimczak edited a comment on pull request #1377:
URL: https://github.com/apache/karaf/pull/1377#issuecomment-841621610


   I can see test is going to fail, I am using MacOS and I have a feeling that due to missing AIO lib in MacOS, Narayana might display slightly different logs in Linux and other systems. Don't have any Linux around unfortunately.
   It is test passing on my machine every time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org