You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2013/10/04 16:30:41 UTC
[jclouds-labs] Use the login resource to authenticate (#27)
Some providers do not expose the "root" api endpoint, so it should be better not used to get the token. The login resource can be used instead.
You can merge this Pull Request by running:
git pull https://github.com/nacx/jclouds-labs auth
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs/pull/27
-- Commit Summary --
* Use the login resource to authenticate
-- File Changes --
M abiquo/src/main/java/org/jclouds/abiquo/functions/auth/GetTokenFromApi.java (2)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/27.patch
https://github.com/jclouds/jclouds-labs/pull/27.diff
Re: [jclouds-labs] Use the login resource to authenticate (#27)
Posted by Andrew Phillips <no...@github.com>.
> I've run them and they work
Nice! Good to go from me, then ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/27#issuecomment-25712107
Re: [jclouds-labs] Use the login resource to authenticate (#27)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #59](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/59/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/27#issuecomment-25703222
Re: [jclouds-labs] Use the login resource to authenticate (#27)
Posted by Ignasi Barrera <no...@github.com>.
All live tests will implicitly run this code. If the authentication token
is not present, this request will be made to get a new one, so in practice,
as long as the live tests don't break (I've run them and they work) this is
working.
El 04/10/2013 17:31, "Andrew Phillips" <no...@github.com> escribió:
> Is there any test that needs to be updated here? Otherwise, +1 - looks
> good to me!
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds-labs/pull/27#issuecomment-25707559>
> .
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/27#issuecomment-25708027
Re: [jclouds-labs] Use the login resource to authenticate (#27)
Posted by Andrew Phillips <no...@github.com>.
Is there any test that needs to be updated here? Otherwise, +1 - looks good to me!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/27#issuecomment-25707559