You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/05/02 07:26:48 UTC
Review Request 46884: LENS-614 : Support single columns as
expressions - like alias
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46884/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-614
https://issues.apache.org/jira/browse/LENS-614
Repository: lens
Description
-------
-Fixed handling of single column expressions in ColumnResolver, AggregateResolver and AliasReplacer
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 1c9d6d2
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 006c4cb
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 1593a54
lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java e629731
lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 58a1d4d
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c3d15d0
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571ee
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 73e6221
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java d54e8b9
Diff: https://reviews.apache.org/r/46884/diff/
Testing
-------
All cube tests pass.
[INFO] Surefire report directory: /d0/jenkins/workspace/Platform_Common_Job/lens-cube/target/surefire-reports
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
Running TestSuite
Tests run: 390, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 383.748 sec - in TestSuite
Results :
Tests run: 390, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Amareshwari Sriramadasu
Re: Review Request 46884: LENS-614 : Support single columns as
expressions - like alias
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46884/#review132414
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On May 9, 2016, 2:12 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46884/
> -----------------------------------------------------------
>
> (Updated May 9, 2016, 2:12 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-614
> https://issues.apache.org/jira/browse/LENS-614
>
>
> Repository: lens
>
>
> Description
> -------
>
> -Fixed handling of single column expressions in ColumnResolver, AggregateResolver and AliasReplacer
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 1c9d6d2
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 006c4cb
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 1593a54
> lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java e629731
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 3f724b6
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 58a1d4d
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c3d15d0
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1f6b66c
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 9ee94d3
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571ee
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 73e6221
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java d54e8b9
>
> Diff: https://reviews.apache.org/r/46884/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.543s]
> [INFO] Lens .............................................. SUCCESS [3.289s]
> [INFO] Lens API .......................................... SUCCESS [21.382s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.541s]
> [INFO] Lens Cube ......................................... SUCCESS [6:58.240s]
> [INFO] Lens DB storage ................................... SUCCESS [14.361s]
> [INFO] Lens Query Library ................................ SUCCESS [11.871s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:24.324s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [30.542s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [14.374s]
> [INFO] Lens Server ....................................... SUCCESS [13:36.892s]
> [INFO] Lens client ....................................... SUCCESS [1:42.944s]
> [INFO] Lens CLI .......................................... SUCCESS [2:08.303s]
> [INFO] Lens Examples ..................................... SUCCESS [9.526s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.608s]
> [INFO] Lens Distribution ................................. SUCCESS [8.864s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:07.662s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.383s]
> [INFO] Lens Regression ................................... SUCCESS [9.465s]
> [INFO] Lens UI ........................................... SUCCESS [44.271s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 31:07.064s
> [INFO] Finished at: Mon May 09 07:54:39 UTC 2016
> [INFO] Final Memory: 166M/2366M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 46884: LENS-614 : Support single columns as
expressions - like alias
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46884/
-----------------------------------------------------------
(Updated May 9, 2016, 8:42 a.m.)
Review request for lens.
Bugs: LENS-614
https://issues.apache.org/jira/browse/LENS-614
Repository: lens
Description
-------
-Fixed handling of single column expressions in ColumnResolver, AggregateResolver and AliasReplacer
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 1c9d6d2
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 006c4cb
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 1593a54
lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java e629731
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 3f724b6
lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 58a1d4d
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c3d15d0
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1f6b66c
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 9ee94d3
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571ee
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 73e6221
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java d54e8b9
Diff: https://reviews.apache.org/r/46884/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.543s]
[INFO] Lens .............................................. SUCCESS [3.289s]
[INFO] Lens API .......................................... SUCCESS [21.382s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.541s]
[INFO] Lens Cube ......................................... SUCCESS [6:58.240s]
[INFO] Lens DB storage ................................... SUCCESS [14.361s]
[INFO] Lens Query Library ................................ SUCCESS [11.871s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:24.324s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [30.542s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [14.374s]
[INFO] Lens Server ....................................... SUCCESS [13:36.892s]
[INFO] Lens client ....................................... SUCCESS [1:42.944s]
[INFO] Lens CLI .......................................... SUCCESS [2:08.303s]
[INFO] Lens Examples ..................................... SUCCESS [9.526s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.608s]
[INFO] Lens Distribution ................................. SUCCESS [8.864s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:07.662s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.383s]
[INFO] Lens Regression ................................... SUCCESS [9.465s]
[INFO] Lens UI ........................................... SUCCESS [44.271s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:07.064s
[INFO] Finished at: Mon May 09 07:54:39 UTC 2016
[INFO] Final Memory: 166M/2366M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 46884: LENS-614 : Support single columns as
expressions - like alias
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46884/
-----------------------------------------------------------
(Updated May 9, 2016, 7:22 a.m.)
Review request for lens.
Bugs: LENS-614
https://issues.apache.org/jira/browse/LENS-614
Repository: lens
Description
-------
-Fixed handling of single column expressions in ColumnResolver, AggregateResolver and AliasReplacer
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 1c9d6d2
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 006c4cb
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 1593a54
lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java e629731
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 3f724b6
lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 58a1d4d
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c3d15d0
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1f6b66c
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 9ee94d3
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571ee
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 73e6221
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java d54e8b9
Diff: https://reviews.apache.org/r/46884/diff/
Testing
-------
All cube tests pass.
[INFO] Surefire report directory: /d0/jenkins/workspace/Platform_Common_Job/lens-cube/target/surefire-reports
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
Running TestSuite
Tests run: 390, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 383.748 sec - in TestSuite
Results :
Tests run: 390, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Amareshwari Sriramadasu
Re: Review Request 46884: LENS-614 : Support single columns as
expressions - like alias
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On May 3, 2016, 4:59 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java, line 581
> > <https://reviews.apache.org/r/46884/diff/1/?file=1368232#file1368232line581>
> >
> > Should it be in HQLParser?
>
> Amareshwari Sriramadasu wrote:
> HQLParser already has one. Since we want to call it in cube.metadata package - copied here.
Moved all usgaes to MetastoreUtil.copyAST. Moved the method because cube.metadata should not depend on cube.parse.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46884/#review131455
-----------------------------------------------------------
On May 9, 2016, 7:22 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46884/
> -----------------------------------------------------------
>
> (Updated May 9, 2016, 7:22 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-614
> https://issues.apache.org/jira/browse/LENS-614
>
>
> Repository: lens
>
>
> Description
> -------
>
> -Fixed handling of single column expressions in ColumnResolver, AggregateResolver and AliasReplacer
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 1c9d6d2
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 006c4cb
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 1593a54
> lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java e629731
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 3f724b6
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 58a1d4d
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c3d15d0
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1f6b66c
> lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java 9ee94d3
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571ee
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 73e6221
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java d54e8b9
>
> Diff: https://reviews.apache.org/r/46884/diff/
>
>
> Testing
> -------
>
> All cube tests pass.
>
> [INFO] Surefire report directory: /d0/jenkins/workspace/Platform_Common_Job/lens-cube/target/surefire-reports
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
> Running TestSuite
> Tests run: 390, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 383.748 sec - in TestSuite
>
> Results :
>
> Tests run: 390, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 46884: LENS-614 : Support single columns as
expressions - like alias
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On May 3, 2016, 4:59 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java, line 581
> > <https://reviews.apache.org/r/46884/diff/1/?file=1368232#file1368232line581>
> >
> > Should it be in HQLParser?
HQLParser already has one. Since we want to call it in cube.metadata package - copied here.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46884/#review131455
-----------------------------------------------------------
On May 2, 2016, 5:26 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46884/
> -----------------------------------------------------------
>
> (Updated May 2, 2016, 5:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-614
> https://issues.apache.org/jira/browse/LENS-614
>
>
> Repository: lens
>
>
> Description
> -------
>
> -Fixed handling of single column expressions in ColumnResolver, AggregateResolver and AliasReplacer
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 1c9d6d2
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 006c4cb
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 1593a54
> lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java e629731
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 58a1d4d
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c3d15d0
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571ee
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 73e6221
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java d54e8b9
>
> Diff: https://reviews.apache.org/r/46884/diff/
>
>
> Testing
> -------
>
> All cube tests pass.
>
> [INFO] Surefire report directory: /d0/jenkins/workspace/Platform_Common_Job/lens-cube/target/surefire-reports
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
> Running TestSuite
> Tests run: 390, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 383.748 sec - in TestSuite
>
> Results :
>
> Tests run: 390, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 46884: LENS-614 : Support single columns as
expressions - like alias
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46884/#review131455
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java (line 581)
<https://reviews.apache.org/r/46884/#comment195446>
Should it be in HQLParser?
- Rajat Khandelwal
On May 2, 2016, 10:56 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46884/
> -----------------------------------------------------------
>
> (Updated May 2, 2016, 10:56 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-614
> https://issues.apache.org/jira/browse/LENS-614
>
>
> Repository: lens
>
>
> Description
> -------
>
> -Fixed handling of single column expressions in ColumnResolver, AggregateResolver and AliasReplacer
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 1c9d6d2
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 006c4cb
> lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 1593a54
> lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java e629731
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 58a1d4d
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java c3d15d0
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571ee
> lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 73e6221
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java d54e8b9
>
> Diff: https://reviews.apache.org/r/46884/diff/
>
>
> Testing
> -------
>
> All cube tests pass.
>
> [INFO] Surefire report directory: /d0/jenkins/workspace/Platform_Common_Job/lens-cube/target/surefire-reports
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
> Running TestSuite
> Tests run: 390, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 383.748 sec - in TestSuite
>
> Results :
>
> Tests run: 390, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>