You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "vinayakphegde (via GitHub)" <gi...@apache.org> on 2023/10/30 15:40:15 UTC
[PR] [YUNIKORN-2084] Remove = in web dockerfile [yunikorn-web]
vinayakphegde opened a new pull request, #143:
URL: https://github.com/apache/yunikorn-web/pull/143
### What is this PR for?
The web Dockerfile contains an extra equal sign that should not be there:
`ARG NODE_VERSION= `
### What type of PR is it?
* [x] - Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2084] Remove = in web dockerfile [yunikorn-web]
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #143: [YUNIKORN-2084] Remove = in web dockerfile
URL: https://github.com/apache/yunikorn-web/pull/143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2084] Remove = in web dockerfile [yunikorn-web]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #143:
URL: https://github.com/apache/yunikorn-web/pull/143#issuecomment-1789977984
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-web/pull/143?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#143](https://app.codecov.io/gh/apache/yunikorn-web/pull/143?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2cde170) into [master](https://app.codecov.io/gh/apache/yunikorn-web/commit/e4e44c3cdbe6e80a61faa9dacfca40d4b284e3a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e4e44c3) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 1 1
Lines 30 30
=======================================
Hits 20 20
Misses 7 7
Partials 3 3
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2084] Remove = in web dockerfile [yunikorn-web]
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #143:
URL: https://github.com/apache/yunikorn-web/pull/143#issuecomment-1789975421
waiting for the build to finish before committing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org