You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Avery Ching (JIRA)" <ji...@apache.org> on 2012/08/17 10:16:37 UTC
[jira] [Updated] (GIRAPH-302) Thread safety issue with sending
partitions around
[ https://issues.apache.org/jira/browse/GIRAPH-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-302:
-------------------------------
Description:
When calling sendPartitionRequest(), we clear the vertex list afterward, making it a race!
I noticed this when I was running with 300 workers and the number of edges wasn't what I expected. Sometimes we get empty requests!
After digging into the code I found the issue and have fixed it.
Giraph Stats Aggregate edges 99,971,220 0 99,971,220
Superstep 11 0 11
Current workers 300 0 300
Last checkpointed superstep 0 0 0
Current master task partition 0 0 0
Sent messages 0 0 0
Aggregate finished vertices 10,000,000 0 10,000,000
Aggregate vertices 10,000,000 0 10,000,000
This is wrong!
Giraph Stats Aggregate edges 100,000,000 0 100,000,000
Superstep 11 0 11
Last checkpointed superstep 0 0 0
Current workers 300 0 300
Current master task partition 0 0 0
Sent messages 0 0 0
Aggregate finished vertices 10,000,000 0 10,000,000
Aggregate vertices 10,000,000 0 10,000,000
Fixed!
Environment: (was: When calling sendPartitionRequest(), we clear the vertex list afterward, making it a race!
I noticed this when I was running with 300 workers and the number of edges wasn't what I expected. Sometimes we get empty requests!
After digging into the code I found the issue and have fixed it.
Giraph Stats Aggregate edges 99,971,220 0 99,971,220
Superstep 11 0 11
Current workers 300 0 300
Last checkpointed superstep 0 0 0
Current master task partition 0 0 0
Sent messages 0 0 0
Aggregate finished vertices 10,000,000 0 10,000,000
Aggregate vertices 10,000,000 0 10,000,000
This is wrong!
Giraph Stats Aggregate edges 100,000,000 0 100,000,000
Superstep 11 0 11
Last checkpointed superstep 0 0 0
Current workers 300 0 300
Current master task partition 0 0 0
Sent messages 0 0 0
Aggregate finished vertices 10,000,000 0 10,000,000
Aggregate vertices 10,000,000 0 10,000,000
Fixed!)
> Thread safety issue with sending partitions around
> --------------------------------------------------
>
> Key: GIRAPH-302
> URL: https://issues.apache.org/jira/browse/GIRAPH-302
> Project: Giraph
> Issue Type: Bug
> Reporter: Avery Ching
> Assignee: Avery Ching
> Priority: Critical
>
> When calling sendPartitionRequest(), we clear the vertex list afterward, making it a race!
> I noticed this when I was running with 300 workers and the number of edges wasn't what I expected. Sometimes we get empty requests!
> After digging into the code I found the issue and have fixed it.
> Giraph Stats Aggregate edges 99,971,220 0 99,971,220
> Superstep 11 0 11
> Current workers 300 0 300
> Last checkpointed superstep 0 0 0
> Current master task partition 0 0 0
> Sent messages 0 0 0
> Aggregate finished vertices 10,000,000 0 10,000,000
> Aggregate vertices 10,000,000 0 10,000,000
> This is wrong!
> Giraph Stats Aggregate edges 100,000,000 0 100,000,000
> Superstep 11 0 11
> Last checkpointed superstep 0 0 0
> Current workers 300 0 300
> Current master task partition 0 0 0
> Sent messages 0 0 0
> Aggregate finished vertices 10,000,000 0 10,000,000
> Aggregate vertices 10,000,000 0 10,000,000
> Fixed!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira