[jira] [Commented] (TAP5-1802) Component tracing check should check if there is a request

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-1802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918934#comment-13918934 ] 

ASF subversion and git services commented on TAP5-1802:
-------------------------------------------------------

Commit c33c963d1d457dfa35a5b4586298a7df5275d41d in tapestry-5's branch refs/heads/master from [~hlship]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=c33c963 ]

TAP5-1802: Avoid an NPE when no Request object is known

Re-organize code to move logic out of ComponentPageElementImpl and into Page and ComponentElementResources.


> Component tracing check should check if there is a request
> ----------------------------------------------------------
>
>                 Key: TAP5-1802
>                 URL: https://issues.apache.org/jira/browse/TAP5-1802
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3
>            Reporter: Denis Stepanov
>            Assignee: Howard M. Lewis Ship
>
> In ComponentPageElementImpl there is a check if request has a parameter to enable component tracing:
>    // should be okay since it's a shadow service object - NOT
>     private final Request request;
>     return !productionMode && (componentTracingEnabled || "true".equals(request.getParameter("t:component-trace")));
> in a case when PageDocumentGenerator is used there is no request and shadow builder will throw an exception.
> Solution would be to use RequestGlobals and check if there is a request. 
>  



--
This message was sent by Atlassian JIRA
(v6.2#6252)