[GitHub] [buildstream-plugins] staehle commented on pull request #29: Revert "Enable setting build-dir"

[GitBox <gi...@apache.org>]

staehle commented on PR #29:
URL: https://github.com/apache/buildstream-plugins/pull/29#issuecomment-1276640907

   Oop, ran into this when updating plugins in my project for the new 1.95.3 release. This change broke API for me :)
   
   We were relying on the 1.95.1 behavior, which while broken for OOT builds, was easy to work around. Previously had this in a .yml file included by project.conf:
   
   ```yml
   # Autotools plugin is broken when trying to do out-of-tree builds. Attempt fix:
   elements:
     autotools:
        variables:
          configure: "%{build-root}/configure %{conf-args}"
   ```
   
   Out-of-tree Autotools builds are mandatory for cross-toolchain components: Binutils, GCC, GLibC
   
   For anyone else this may affect, you can update to the new plugins release version and use this updated shim in your project instead to revert to the old autotools behavior: 
   
   ```yml
   elements:
     autotools:
       variables:
         build-dir: "."
         configure: "%{build-root}/configure %{conf-args}"
         make-args: >-
           -C "%{build-dir}"
       config:
         configure-commands:
         - |
           %{autogen}
         - |
           mkdir -p "%{build-dir}"
           cd "%{build-dir}"
           %{configure}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org