You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ha...@apache.org on 2022/01/26 07:23:09 UTC
[skywalking-banyandb] branch main updated: fix two typos (#72)
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new 3eb82d4 fix two typos (#72)
3eb82d4 is described below
commit 3eb82d44ea381451c0272b7751b906afd4310c48
Author: Jiajing LU <lu...@gmail.com>
AuthorDate: Wed Jan 26 15:18:39 2022 +0800
fix two typos (#72)
---
banyand/metadata/schema/etcd.go | 4 ++--
banyand/stream/service.go | 9 +++++++--
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/banyand/metadata/schema/etcd.go b/banyand/metadata/schema/etcd.go
index 7836ca2..7695175 100644
--- a/banyand/metadata/schema/etcd.go
+++ b/banyand/metadata/schema/etcd.go
@@ -560,8 +560,8 @@ func (e *etcdSchemaRegistry) listWithPrefix(ctx context.Context, prefix string,
entities[i] = message
if messageWithMetadata, ok := message.(HasMetadata); ok {
// Assign readonly fields
- messageWithMetadata.GetMetadata().CreateRevision = resp.Kvs[0].CreateRevision
- messageWithMetadata.GetMetadata().ModRevision = resp.Kvs[0].ModRevision
+ messageWithMetadata.GetMetadata().CreateRevision = resp.Kvs[i].CreateRevision
+ messageWithMetadata.GetMetadata().ModRevision = resp.Kvs[i].ModRevision
}
}
return entities, nil
diff --git a/banyand/stream/service.go b/banyand/stream/service.go
index df3985b..345f888 100644
--- a/banyand/stream/service.go
+++ b/banyand/stream/service.go
@@ -218,9 +218,14 @@ func (s *service) OnAddOrUpdate(m schema.Metadata) {
metadata: m.Spec.(*databasev1.Stream).GetMetadata(),
}
case schema.KindIndexRuleBinding:
- if m.Spec.(*databasev1.IndexRuleBinding).GetSubject().Catalog == commonv1.Catalog_CATALOG_STREAM {
+ irb, ok := m.Spec.(*databasev1.IndexRuleBinding)
+ if !ok {
+ s.l.Warn().Msg("fail to convert message to IndexRuleBinding")
+ return
+ }
+ if irb.GetSubject().Catalog == commonv1.Catalog_CATALOG_STREAM {
stm, err := s.metadata.StreamRegistry().GetStream(context.TODO(), &commonv1.Metadata{
- Name: m.Name,
+ Name: irb.GetSubject().GetName(),
Group: m.Group,
})
if err != nil {