[GitHub] [incubator-uniffle] crain-cn commented on a diff in pull request #638: [#545][FOLLOWUP]feat(operator): support specifying custom tolerations

["crain-cn (via GitHub)" <gi...@apache.org>]

crain-cn commented on code in PR #638:
URL: https://github.com/apache/incubator-uniffle/pull/638#discussion_r1113095335


##########
deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go:
##########
@@ -249,6 +253,15 @@ type MainContainer struct {
 	// VolumeMounts indicates describes mountings of volumes within shuffle servers' container.
 	// +optional
 	VolumeMounts []corev1.VolumeMount `json:"volumeMounts,omitempty"`
+
+	// NodeSelector is a selector which must be true for the pod to fit on a node.
+	// Selector which must match a node's labels for the pod to be scheduled on that node.
+	// +optional
+	NodeSelector map[string]string `json:"nodeSelector,omitempty"`
+
+	// Indicates the tolerations the pods under this subset have.
+	// +optional
+	Tolerations []corev1.Toleration `json:"tolerations,omitempty"`

Review Comment:
   The fields in MainContainer have been removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org