You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2015/04/08 03:00:58 UTC
[GitHub] spark pull request: [SPARK-6506] [pyspark] Do not try to retrieve ...
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/5405
[SPARK-6506] [pyspark] Do not try to retrieve SPARK_HOME when not needed...
....
In particular, this makes pyspark in yarn-cluster mode fail unless
SPARK_HOME is set, when it's not really needed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vanzin/spark SPARK-6506
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5405.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5405
----
commit e184507eba7f02fd5b97ae3a6bede7e81edbea8b
Author: Marcelo Vanzin <va...@cloudera.com>
Date: 2015-04-08T00:59:53Z
[SPARK-6506] [pyspark] Do not try to retrieve SPARK_HOME when not needed.
In particular, this makes pyspark in yarn-cluster mode fail unless
SPARK_HOME is set, when it's not really needed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6506] [pyspark] Do not try to retrieve ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5405#issuecomment-90771958
[Test build #29820 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29820/consoleFull) for PR 5405 at commit [`e184507`](https://github.com/apache/spark/commit/e184507eba7f02fd5b97ae3a6bede7e81edbea8b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6506] [pyspark] Do not try to retrieve ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5405
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6506] [pyspark] Do not try to retrieve ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5405#issuecomment-90784177
[Test build #29820 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29820/consoleFull) for PR 5405 at commit [`e184507`](https://github.com/apache/spark/commit/e184507eba7f02fd5b97ae3a6bede7e81edbea8b).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6506] [pyspark] Do not try to retrieve ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5405#issuecomment-90784192
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29820/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6506] [pyspark] Do not try to retrieve ...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5405#issuecomment-90977998
LGTM. Although this code has been around for many revisions, it only causes a problem for YARN Cluster mode, which we've only supported since Spark 1.3, so I'm going to merge this into `master` (1.4.0) and `branch-1.3` (1.3.2). Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org