You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/12/19 20:35:16 UTC

[GitHub] [hbase] saintstack commented on a change in pull request #2784: [PATCH] Add "regexstringnocase" to ParseFilter for case-insensitivity

saintstack commented on a change in pull request #2784:
URL: https://github.com/apache/hbase/pull/2784#discussion_r546279930



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ParseConstants.java
##########
@@ -244,6 +244,13 @@
   public static final byte [] regexStringType = new byte [] {'r','e','g','e', 'x',
                                                              's','t','r','i','n','g'};
 
+  /**
+   * RegexStringNoCaseType byte array
+   */
+  public static final byte [] regexStringNoCaseType = new byte [] {'r','e','g','e','x',

Review comment:
       Not your fault but usually we capitalize static variable names. This is ok for now. We can change in another PR




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org