You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/06/07 08:42:53 UTC
Review Request 48324: LENS-1167: If result formatting failed for a
query, NPE is thrown while persisting the query context on restart
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48324/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1167
https://issues.apache.org/jira/browse/LENS-1167
Repository: lens
Description
-------
Diffs
-----
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 2cd6b3f3944c45978a82759cc39b3d542e1f7aad
Diff: https://reviews.apache.org/r/48324/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 48324: LENS-1167: If result formatting failed for
a query, NPE is thrown while persisting the query context on restart
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48324/#review136753
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On June 8, 2016, 2:02 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48324/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 2:02 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1167
> https://issues.apache.org/jira/browse/LENS-1167
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 2cd6b3f3944c45978a82759cc39b3d542e1f7aad
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java f465e9d476421da5ab5b51ed1c050b0d0d38e0bf
>
> Diff: https://reviews.apache.org/r/48324/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 48324: LENS-1167: If result formatting failed for
a query, NPE is thrown while persisting the query context on restart
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48324/
-----------------------------------------------------------
(Updated June 8, 2016, 7:32 p.m.)
Review request for lens.
Bugs: LENS-1167
https://issues.apache.org/jira/browse/LENS-1167
Repository: lens
Description
-------
Diffs (updated)
-----
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 2cd6b3f3944c45978a82759cc39b3d542e1f7aad
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java f465e9d476421da5ab5b51ed1c050b0d0d38e0bf
Diff: https://reviews.apache.org/r/48324/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 48324: LENS-1167: If result formatting failed for
a query, NPE is thrown while persisting the query context on restart
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48324/
-----------------------------------------------------------
(Updated June 8, 2016, 3:04 p.m.)
Review request for lens.
Bugs: LENS-1167
https://issues.apache.org/jira/browse/LENS-1167
Repository: lens
Description
-------
Diffs (updated)
-----
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 2cd6b3f3944c45978a82759cc39b3d542e1f7aad
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java f465e9d476421da5ab5b51ed1c050b0d0d38e0bf
Diff: https://reviews.apache.org/r/48324/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 48324: LENS-1167: If result formatting failed for
a query, NPE is thrown while persisting the query context on restart
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On June 8, 2016, 9:51 a.m., Amareshwari Sriramadasu wrote:
> > lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java, line 97
> > <https://reviews.apache.org/r/48324/diff/1/?file=1408677#file1408677line97>
> >
> > what about metadata being null ?
>
> Amareshwari Sriramadasu wrote:
> Should we reset QueryOutputFormatter to null in ResultFormatter when exceptions occur ?
Added the logic for resetting formatter to null. Still keeping the current changes.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48324/#review136588
-----------------------------------------------------------
On June 8, 2016, 3:04 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48324/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 3:04 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1167
> https://issues.apache.org/jira/browse/LENS-1167
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 2cd6b3f3944c45978a82759cc39b3d542e1f7aad
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java f465e9d476421da5ab5b51ed1c050b0d0d38e0bf
>
> Diff: https://reviews.apache.org/r/48324/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 48324: LENS-1167: If result formatting failed for
a query, NPE is thrown while persisting the query context on restart
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On June 8, 2016, 4:21 a.m., Amareshwari Sriramadasu wrote:
> > lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java, line 97
> > <https://reviews.apache.org/r/48324/diff/1/?file=1408677#file1408677line97>
> >
> > what about metadata being null ?
Should we reset QueryOutputFormatter to null in ResultFormatter when exceptions occur ?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48324/#review136588
-----------------------------------------------------------
On June 7, 2016, 8:42 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48324/
> -----------------------------------------------------------
>
> (Updated June 7, 2016, 8:42 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1167
> https://issues.apache.org/jira/browse/LENS-1167
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 2cd6b3f3944c45978a82759cc39b3d542e1f7aad
>
> Diff: https://reviews.apache.org/r/48324/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 48324: LENS-1167: If result formatting failed for
a query, NPE is thrown while persisting the query context on restart
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48324/#review136588
-----------------------------------------------------------
lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java (line 97)
<https://reviews.apache.org/r/48324/#comment201674>
what about metadata being null ?
- Amareshwari Sriramadasu
On June 7, 2016, 8:42 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48324/
> -----------------------------------------------------------
>
> (Updated June 7, 2016, 8:42 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1167
> https://issues.apache.org/jira/browse/LENS-1167
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java 2cd6b3f3944c45978a82759cc39b3d542e1f7aad
>
> Diff: https://reviews.apache.org/r/48324/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>