You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2025/12/16 17:33:19 UTC

[PR] [fix][build] Activate jdk21 and jdk24 profiles on Java 25 [pulsar]

lhotari opened a new pull request, #25084:
URL: https://github.com/apache/pulsar/pull/25084

   ### Motivation
   
   There's currently profiles for `jdk21` and `jdk24` which get activated when the Java version is exactly Java 21 or Java 24. These profiles are intended to be used when the build JVM is the same version or greater. This is necessary for better support for Java 25 builds. 
   
   ### Modifications
   
   - use version rule "equal or greater" for jdk21 and jdk24 profiles
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][build] Activate jdk21 and jdk24 profiles on Java 25 [pulsar]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #25084:
URL: https://github.com/apache/pulsar/pull/25084#issuecomment-3663428382

   ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/25084?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 74.47%. Comparing base ([`3efc174`](https://app.codecov.io/gh/apache/pulsar/commit/3efc174f42de22523c51608858aef581b8743509?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c13496d`](https://app.codecov.io/gh/apache/pulsar/commit/c13496d4beb8c863a2fd979ccbc94a012a7adf2a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/pulsar/pull/25084/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/pulsar/pull/25084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #25084       +/-   ##
   =============================================
   + Coverage     38.49%   74.47%   +35.98%     
   - Complexity    13275    33536    +20261     
   =============================================
     Files          1864     1899       +35     
     Lines        146403   149633     +3230     
     Branches      17012    17396      +384     
   =============================================
   + Hits          56354   111436    +55082     
   + Misses        82341    29312    -53029     
   - Partials       7708     8885     +1177     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/25084/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/25084/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.37% <ø> (-0.01%)` | :arrow_down: |
   | [systests](https://app.codecov.io/gh/apache/pulsar/pull/25084/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.01% <ø> (+0.24%)` | :arrow_up: |
   | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/25084/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.00% <ø> (+39.35%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   [see 1414 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/25084/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][build] Activate jdk21 and jdk24 profiles on Java 25 [pulsar]

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- merged PR #25084:
URL: https://github.com/apache/pulsar/pull/25084


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org