You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff via Review Board <no...@reviews.apache.org> on 2018/07/09 23:46:36 UTC

Review Request 67859: Updated apply-reviews.py messaging for submitted reviews.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67859/
-----------------------------------------------------------

Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-7397
    https://issues.apache.org/jira/browse/MESOS-7397


Repository: mesos


Description
-------

Updated apply-reviews.py messaging for submitted reviews.


Diffs
-----

  support/apply-reviews.py edddefb75b1acca90378e79b3533c7a565110542 
  support/python3/apply-reviews.py bf72c809020b976b401413b994608280068dcfd2 


Diff: https://reviews.apache.org/r/67859/diff/1/


Testing
-------

Manually tested on an already submitted review-request.


Thanks,

Till Toenshoff


Re: Review Request 67859: Updated apply-reviews.py messaging for submitted reviews.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67859/#review205910
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67859]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 9, 2018, 11:46 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67859/
> -----------------------------------------------------------
> 
> (Updated July 9, 2018, 11:46 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-7397
>     https://issues.apache.org/jira/browse/MESOS-7397
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated apply-reviews.py messaging for submitted reviews.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py edddefb75b1acca90378e79b3533c7a565110542 
>   support/python3/apply-reviews.py bf72c809020b976b401413b994608280068dcfd2 
> 
> 
> Diff: https://reviews.apache.org/r/67859/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested on an already submitted review-request.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 67859: Updated apply-reviews.py messaging for submitted reviews.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67859/#review205918
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On July 9, 2018, 4:46 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67859/
> -----------------------------------------------------------
> 
> (Updated July 9, 2018, 4:46 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-7397
>     https://issues.apache.org/jira/browse/MESOS-7397
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated apply-reviews.py messaging for submitted reviews.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py edddefb75b1acca90378e79b3533c7a565110542 
>   support/python3/apply-reviews.py bf72c809020b976b401413b994608280068dcfd2 
> 
> 
> Diff: https://reviews.apache.org/r/67859/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested on an already submitted review-request.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Re: Review Request 67859: Updated apply-reviews.py messaging for submitted reviews.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67859/#review205882
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67859']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1888/mesos-review-67859

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1888/mesos-review-67859/logs/mesos-tests-stdout.log):

```
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (680 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (705 ms total)

[----------] Global test environment tear-down
d:\dcos\mesos\mesos\src\tests\environment.cpp(997): error: Failed
Tests completed with child processes remaining:
-+- 21704 00000052C60FE75C
 |-+- 18916 00000052C60FE75C
 | --- 22880 00000052C60FE75C
 |-+- 19644 00000052C60FE75C
 | --- 17692 00000052C60FE75C
 |-+- 20224 00000052C60FE75C
 | --- 21040 00000052C60FE75C
 |-+- 20896 00000052C60FE75C
 | --- 23416 00000052C60FE75C
 |-+- 21640 00000052C60FE75C
 | --- 23424 00000052C60FE75C
 |-+- 21980 00000052C60FE75C
 | --- 21516 00000052C60FE75C
 -+- 23192 00000052C60FE75C
   --- 16544 00000052C60FE75C
[==========] 1010 tests from 98 test cases ran. (510545 ms total)
[  PASSED  ] 1010 tests.
[  FAILED  ] 0 tests, listed below:

 0 FAILED TESTS

  YOU HAVE 222 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1888/mesos-review-67859/logs/mesos-tests-stderr.log):

```
I0710 00:49:25.516950 21580 slave.cpp:3939] Shutting down framework 7f0892a0-5ead-49b1-9d76-e767d98c886f-0000
I0710 00:49:25.516950  3512 master.cpp:11033] Updating the state of task e80d238b-f6ce-43f2-84cb-f102cb0e20b2 of framework 7f0892a0-5ead-49b1-9d76-e767d98c886f-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0710 00:49:25.516950 21580 slave.cpp:6660] Shutting down executor 'e80d238b-f6ce-43f2-84cb-f102cb0e20b2' of framework 7f0892a0-5ead-49b1-9d76-e767d98c886f-0000 at executor(1)@192.10.1.6:63205
I0710 00:49:25.518962 21580 slave.cpp:931] Agent terminating
W0710 00:49:25.518962 21580 slave.cpp:3935] Ignoring shutdown framework 7f0892a0-5ead-49b1-9d76-e767d98c886f-0000 because it is terminating
I0710 00:49:25.519950  3512 master.cpp:11132] Removing task e80d238b-f6ce-43f2-84cb-f102cb0e20b2 with resources cpus(allocated: *):4; mI0710 00:49:25.356082 13252 exec.cpp:162] Version: 1.7.0
I0710 00:49:25.382966 22736 exec.cpp:236] Executor registered on agent 7f0892a0-5ead-49b1-9d76-e767d98c886f-S0
I0710 00:49:25.386948 18340 executor.cpp:182] Received SUBSCRIBED event
I0710 00:49:25.391954 18340 executor.cpp:186] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
I0710 00:49:25.391954 18340 executor.cpp:182] Received LAUNCH event
I0710 00:49:25.395943 18340 executor.cpp:679] Starting task e80d238b-f6ce-43f2-84cb-f102cb0e20b2
I0710 00:49:25.477941 18340 executor.cpp:499] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0710 00:49:25.489941 18340 executor.cpp:693] Forked command at 18452
I0710 00:49:25.518962 23292 exec.cpp:445] Executor asked to shutdown
I0710 00:49:25.519950 18340 executor.cpp:182] Received SHUTDOWN event
I0710 00:49:25.519950 18340 executor.cpp:796] Shutting down
I0710 00:49:25.519950 18340 executor.cpp:909] Sending SIGTERM to process tree at pid 18em(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 7f0892a0-5ead-49b1-9d76-e767d98c886f-0000 on agent 7f0892a0-5ead-49b1-9d76-e767d98c886f-S0 at slave(462)@192.10.1.6:61500 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0710 00:49:25.522969  3512 master.cpp:1330] Agent 7f0892a0-5ead-49b1-9d76-e767d98c886f-S0 at slave(462)@192.10.1.6:61500 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0710 00:49:25.522969  3512 master.cpp:3340] Disconnecting agent 7f0892a0-5ead-49b1-9d76-e767d98c886f-S0 at slave(462)@192.10.1.6:61500 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0710 00:49:25.522969  3512 master.cpp:3359] Deactivating agent 7f0892a0-5ead-49b1-9d76-e767d98c886f-S0 at slave(462)@192.10.1.6:61500 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0710 00:49:25.523941 20420 containerizer.cpp:2407] Destroying container aa0b40a2-760d-4c3c-becd-15a1eb5b85fd in RUNNING state
I0710 00:49:25.523941 20420 containerizer.cpp:3021] Transitioning the state of container aa0b40a2-760d-4c3c-becd-15a1eb5b85fd from RUNNING to DESTROYING
I0710 00:49:25.524947 20420 launcher.cpp:155] Asked to destroy container aa0b40a2-760d-4c3c-becd-15a1eb5b85fd
I0710 00:49:25.524947 20692 hierarchical.cpp:346] Removed framework 7f0892a0-5ead-49b1-9d76-e767d98c886f-0000
I0710 00:49:25.524947 20692 hierarchical.cpp:769] Agent 7f0892a0-5ead-49b1-9d76-e767d98c886f-S0 deactivated
I0710 00:49:25.574947 22940 containerizer.cpp:2860] Container aa0b40a2-760d-4c3c-becd-15a1eb5b85fd has exited
I0710 00:49:25.604955  2576 master.cpp:1172] Master terminating
I0710 00:49:25.606946 21580 hierarchical.cpp:612] Removed agent 7f0892a0-5ead-49b1-9d76-e767d98c886f-S0
I0710 00:49:25.970538 21664 process.cpp:926] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On July 9, 2018, 11:46 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67859/
> -----------------------------------------------------------
> 
> (Updated July 9, 2018, 11:46 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-7397
>     https://issues.apache.org/jira/browse/MESOS-7397
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated apply-reviews.py messaging for submitted reviews.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py edddefb75b1acca90378e79b3533c7a565110542 
>   support/python3/apply-reviews.py bf72c809020b976b401413b994608280068dcfd2 
> 
> 
> Diff: https://reviews.apache.org/r/67859/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested on an already submitted review-request.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>