You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/18 15:37:43 UTC
[GitHub] [incubator-druid] gianm commented on issue #6909: Remove
CardinalityAggregatorColumnSelectorStrategy and
CardinalityAggregatorColumnSelectorStrategyFactory as too shallow
abstractions.
gianm commented on issue #6909: Remove CardinalityAggregatorColumnSelectorStrategy and CardinalityAggregatorColumnSelectorStrategyFactory as too shallow abstractions.
URL: https://github.com/apache/incubator-druid/issues/6909#issuecomment-484564986
I accidentally stumbled into this by suggesting the _opposite_ refactoring on #7496: https://github.com/apache/incubator-druid/pull/7496#discussion_r276413326. I think the way that CardinalityAggregator works now is pretty nice, for the reasons I mentioned in that thread. I'm not really interested in requiring that _everything_ be done that way but I did want to speak up for why the design is the way it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org