You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@zookeeper.apache.org by "Brittany Barnes (Jira)" <ji...@apache.org> on 2020/02/26 18:29:00 UTC
[jira] [Commented] (ZOOKEEPER-3728) move traceMask calculation
logic into the trace log in the FinalRequestProcessor#processRequest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17045792#comment-17045792 ]
Brittany Barnes commented on ZOOKEEPER-3728:
--------------------------------------------
[~maoling] Thank you for the review. Are you able to merge for me in Github? This will be my first commit.
> move traceMask calculation logic into the trace log in the FinalRequestProcessor#processRequest
> -----------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-3728
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3728
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Reporter: maoling
> Assignee: Brittany Barnes
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code:java}
> LOG.debug("Processing request:: {}", request);
> // request.addRQRec(">final");
> long traceMask = ZooTrace.CLIENT_REQUEST_TRACE_MASK;
> if (request.type == OpCode.ping) {
> traceMask = ZooTrace.SERVER_PING_TRACE_MASK;
> }
> if (LOG.isTraceEnabled()) {
> ZooTrace.logRequest(LOG, traceMask, 'E', request, "");
> }
> {code}
> # remove the useless *// request.addRQRec(">final");*
> # most read/write requests will hit the code here but useless when Log Trace disable. we need to move traceMask calculation logic into the LOG.isTraceEnabled()
--
This message was sent by Atlassian Jira
(v8.3.4#803005)