You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "akashsawan1 (via GitHub)" <gi...@apache.org> on 2023/04/17 15:17:14 UTC
[GitHub] [eventmesh] akashsawan1 opened a new pull request, #3754: Update ClientAckContext.java
akashsawan1 opened a new pull request, #3754:
URL: https://github.com/apache/eventmesh/pull/3754
Fixes#<3393>
Motivation
Explain why you want to make the changes and what problem you're trying to solve.
I am interested in open source, it will help to keep me motivated to learn and help the community
Modifications
Describe the modifications you've done.
Did some code optimization in line 49,58
Documentation
Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] akashsawan1 commented on pull request #3754: Update ClientAckContext.java
Posted by "akashsawan1 (via GitHub)" <gi...@apache.org>.
akashsawan1 commented on PR #3754:
URL: https://github.com/apache/eventmesh/pull/3754#issuecomment-1513155383
>
solved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on a diff in pull request #3754: Update ClientAckContext.java
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3754:
URL: https://github.com/apache/eventmesh/pull/3754#discussion_r1170736187
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/ClientAckContext.java:
##########
@@ -32,6 +32,7 @@
import lombok.extern.slf4j.Slf4j;
+import java.util.Objects;
Review Comment:
`import java.util.Objects;` should be placed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3754: Update ClientAckContext.java
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3754:
URL: https://github.com/apache/eventmesh/pull/3754#issuecomment-1523098106
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3754?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3754](https://codecov.io/gh/apache/eventmesh/pull/3754?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb61a50) into [master](https://codecov.io/gh/apache/eventmesh/commit/85cf89ff6e4e026760657bb1da883f918bcf9309?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85cf89f) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head fb61a50 differs from pull request most recent head 280c75a. Consider uploading reports for the commit 280c75a to get more accurate results
```diff
@@ Coverage Diff @@
## master #3754 +/- ##
============================================
- Coverage 13.76% 13.75% -0.01%
Complexity 1291 1291
============================================
Files 571 571
Lines 29231 29222 -9
Branches 2881 2868 -13
============================================
- Hits 4024 4020 -4
+ Misses 24833 24829 -4
+ Partials 374 373 -1
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3754?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...re/protocol/http/processor/HeartBeatProcessor.java](https://codecov.io/gh/apache/eventmesh/pull/3754?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvSGVhcnRCZWF0UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ocol/tcp/client/session/push/ClientAckContext.java](https://codecov.io/gh/apache/eventmesh/pull/3754?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL3B1c2gvQ2xpZW50QWNrQ29udGV4dC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/eventmesh/client/selector/ServiceInstance.java](https://codecov.io/gh/apache/eventmesh/pull/3754?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L3NlbGVjdG9yL1NlcnZpY2VJbnN0YW5jZS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../eventmesh/spi/loader/JarExtensionClassLoader.java](https://codecov.io/gh/apache/eventmesh/pull/3754?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3NwaS9sb2FkZXIvSmFyRXh0ZW5zaW9uQ2xhc3NMb2FkZXIuamF2YQ==) | `13.55% <0.00%> (ø)` | |
| [...tmesh/webhook/receive/protocol/GithubProtocol.java](https://codecov.io/gh/apache/eventmesh/pull/3754?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXdlYmhvb2svZXZlbnRtZXNoLXdlYmhvb2stcmVjZWl2ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3dlYmhvb2svcmVjZWl2ZS9wcm90b2NvbC9HaXRodWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (ø)` | |
... and [7 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3754/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] akashsawan1 commented on pull request #3754: Update ClientAckContext.java
Posted by "akashsawan1 (via GitHub)" <gi...@apache.org>.
akashsawan1 commented on PR #3754:
URL: https://github.com/apache/eventmesh/pull/3754#issuecomment-1512427146
Could anyone help why some of checks failed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] akashsawan1 commented on a diff in pull request #3754: Update ClientAckContext.java
Posted by "akashsawan1 (via GitHub)" <gi...@apache.org>.
akashsawan1 commented on code in PR #3754:
URL: https://github.com/apache/eventmesh/pull/3754#discussion_r1170761311
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/push/ClientAckContext.java:
##########
@@ -32,6 +32,7 @@
import lombok.extern.slf4j.Slf4j;
+import java.util.Objects;
Review Comment:
resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3754: Update ClientAckContext.java
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3754:
URL: https://github.com/apache/eventmesh/pull/3754#issuecomment-1512617809
Missing import:
import java.util.Objects;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3754: [ISSUE #3393] Do some code optimization.[ClientAckContext]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3754:
URL: https://github.com/apache/eventmesh/pull/3754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org