You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2020/11/24 09:03:10 UTC

svn commit: r1883779 - in /pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools: TestExtractText.java TestPDFText2HTML.java TestTextToPdf.java imageio/TestImageIOUtils.java

Author: msahyoun
Date: Tue Nov 24 09:03:10 2020
New Revision: 1883779

URL: http://svn.apache.org/viewvc?rev=1883779&view=rev
Log:
PDFBOX-5017: sonar fixes; change visibility

Modified:
    pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestExtractText.java
    pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestPDFText2HTML.java
    pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestTextToPdf.java
    pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java

Modified: pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestExtractText.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestExtractText.java?rev=1883779&r1=1883778&r2=1883779&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestExtractText.java (original)
+++ pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestExtractText.java Tue Nov 24 09:03:10 2020
@@ -27,7 +27,7 @@ import org.junit.jupiter.api.Test;
 /**
  * Test suite for ExtractText. 
  */
-public class TestExtractText
+class TestExtractText
 {
     
     /**
@@ -36,7 +36,7 @@ public class TestExtractText
      * @throws Exception if something went wrong
      */
     @Test
-    public void testEmbeddedPDFs() throws Exception 
+    void testEmbeddedPDFs() throws Exception 
     {
         ByteArrayOutputStream outBytes = new ByteArrayOutputStream();
         PrintStream stdout = System.out;

Modified: pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestPDFText2HTML.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestPDFText2HTML.java?rev=1883779&r1=1883778&r2=1883779&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestPDFText2HTML.java (original)
+++ pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestPDFText2HTML.java Tue Nov 24 09:03:10 2020
@@ -32,7 +32,7 @@ import org.apache.pdfbox.pdmodel.font.PD
 import org.apache.pdfbox.text.PDFTextStripper;
 import org.junit.jupiter.api.Test;
 
-public class TestPDFText2HTML
+class TestPDFText2HTML
 {
     private PDDocument createDocument(String title, PDFont font, String text) throws IOException
     {
@@ -52,7 +52,7 @@ public class TestPDFText2HTML
     }
 
     @Test
-    public void testEscapeTitle() throws IOException
+    void testEscapeTitle() throws IOException
     {
         PDFTextStripper stripper = new PDFText2HTML();
         PDDocument doc = createDocument("<script>\u3042", PDType1Font.HELVETICA, "<foo>");
@@ -65,7 +65,7 @@ public class TestPDFText2HTML
     }
 
     @Test
-    public void testStyle() throws IOException
+    void testStyle() throws IOException
     {
         PDFTextStripper stripper = new PDFText2HTML();
         PDDocument doc = createDocument("t", PDType1Font.HELVETICA_BOLD, "<bold>");

Modified: pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestTextToPdf.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestTextToPdf.java?rev=1883779&r1=1883778&r2=1883779&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestTextToPdf.java (original)
+++ pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/TestTextToPdf.java Tue Nov 24 09:03:10 2020
@@ -27,13 +27,13 @@ import org.junit.jupiter.api.Test;
 /**
  * Test suite for TextToPDF.
  */
-public class TestTextToPdf
+class TestTextToPdf
 {
     /**
      * This test ensures that a PDF created from an empty String is still readable by Adobe Reader
      */
     @Test
-    public void testCreateEmptyPdf() throws Exception
+    void testCreateEmptyPdf() throws Exception
     {
         TextToPDF pdfCreator = new TextToPDF();
         PDDocument pdfDoc;

Modified: pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java?rev=1883779&r1=1883778&r2=1883779&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java (original)
+++ pdfbox/trunk/tools/src/test/java/org/apache/pdfbox/tools/imageio/TestImageIOUtils.java Tue Nov 24 09:03:10 2020
@@ -63,7 +63,7 @@ import org.w3c.dom.NodeList;
 /**
  * Test suite for ImageIOUtil.
  */
-public class TestImageIOUtils
+class TestImageIOUtils
 {
     private static final Log LOG = LogFactory.getLog(TestImageIOUtils.class);
     
@@ -287,7 +287,7 @@ public class TestImageIOUtils
      * @throws Exception when there is an exception
      */
     @Test
-    public void testRenderImage() throws Exception
+    void testRenderImage() throws Exception
     {
         String inDir = "src/test/resources/input/ImageIOUtil";
         String outDir = "target/test-output/ImageIOUtil/";
@@ -328,7 +328,7 @@ public class TestImageIOUtils
             checkBmpResolution(filename, expectedResolution);
             return;
         }
-        Iterator readers = ImageIO.getImageReadersBySuffix(suffix);
+        Iterator<ImageReader> readers = ImageIO.getImageReadersBySuffix(suffix);
         assertTrue(readers.hasNext(), "No image reader found for suffix " + suffix);
         ImageReader reader = (ImageReader) readers.next();
         try (ImageInputStream iis = ImageIO.createImageInputStream(new File(filename)))
@@ -395,7 +395,7 @@ public class TestImageIOUtils
      */
     void checkTiffCompression(String filename, String expectedCompression) throws IOException
     {
-        Iterator readers = ImageIO.getImageReadersBySuffix("tiff");
+        Iterator<ImageReader> readers = ImageIO.getImageReadersBySuffix("tiff");
         ImageReader reader = (ImageReader) readers.next();
         try (ImageInputStream iis = ImageIO.createImageInputStream(new File(filename)))
         {