You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2018/05/31 22:17:01 UTC

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

Sailesh Mukil has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10563


Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3"
......................................................................

Revert "IMPALA-5893: Remove old kinit code for Impala 3"

This reverts commit 4dc3d340d866ef9a7ef1f654cbfff402e0bc69cc.

Due to IMPALA-7072, we still need to keep the old way of Kinit-ing
around for some specific configurations as a fallback.

Change-Id: Idbcce96a1fab23445f42d224ca397897aa90e07d
---
M be/src/common/global-flags.cc
M be/src/rpc/auth-provider.h
M be/src/rpc/authentication.cc
M be/src/rpc/rpc-mgr-kerberized-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/testutil/mini-kdc-wrapper.h
6 files changed, 110 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/63/10563/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbcce96a1fab23445f42d224ca397897aa90e07d
Gerrit-Change-Number: 10563
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10563 )

Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3"
......................................................................


Patch Set 1:

Do we have a plan for addressing IMPALA-7072 and removing this code again? Or do we think we need to keep this code around forever (which would be unfortunate given the fork() problem)?


-- 
To view, visit http://gerrit.cloudera.org:8080/10563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbcce96a1fab23445f42d224ca397897aa90e07d
Gerrit-Change-Number: 10563
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 00:31:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10563 )

Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3"
......................................................................


Patch Set 1:

Is this a clean revert ?


-- 
To view, visit http://gerrit.cloudera.org:8080/10563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbcce96a1fab23445f42d224ca397897aa90e07d
Gerrit-Change-Number: 10563
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 May 2018 23:12:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10563 )

Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3"
......................................................................


Patch Set 1: Code-Review+2

Please run some sanity tests (e.g. thrift with kudu kinit disabled) before merging.


-- 
To view, visit http://gerrit.cloudera.org:8080/10563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbcce96a1fab23445f42d224ca397897aa90e07d
Gerrit-Change-Number: 10563
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 May 2018 23:43:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10563 )

Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3"
......................................................................


Patch Set 1:

> Is this a clean revert ?

Yes, the revert was clean.


-- 
To view, visit http://gerrit.cloudera.org:8080/10563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbcce96a1fab23445f42d224ca397897aa90e07d
Gerrit-Change-Number: 10563
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 May 2018 23:15:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/10563 )

Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3"
......................................................................


Abandoned

I'm going to mark this as abandoned for now so that it doesn't show up in open CR searches. Feel free to revive it if needed.
-- 
To view, visit http://gerrit.cloudera.org:8080/10563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Idbcce96a1fab23445f42d224ca397897aa90e07d
Gerrit-Change-Number: 10563
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@gmail.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10563 )

Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3"
......................................................................


Patch Set 1:

I think you'll need to add a couple of discard_result calls here to pass clang-tidy after you rebase:

https://gerrit.cloudera.org/#/c/10715/1..2


-- 
To view, visit http://gerrit.cloudera.org:8080/10563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbcce96a1fab23445f42d224ca397897aa90e07d
Gerrit-Change-Number: 10563
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 16:50:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Revert "IMPALA-5893: Remove old kinit code for Impala 3"

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10563 )

Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3"
......................................................................


Patch Set 1: -Code-Review

Hi Sailesh, this patch may not be needed anymore due to IMPALA-7212. I suppose we just need to fix Kudu Kerberos as we discover bugs. We can proactively write more test cases to test out different configuration.


-- 
To view, visit http://gerrit.cloudera.org:8080/10563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbcce96a1fab23445f42d224ca397897aa90e07d
Gerrit-Change-Number: 10563
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 02:26:49 +0000
Gerrit-HasComments: No