You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/05 07:19:10 UTC
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz opened a new pull request #715: (ios): fix regression in 2706f34
NiklasMerz opened a new pull request #715:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/715
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Fix Merging issue from #656
Closes #714
### Description
<!-- Describe your changes in detail -->
Remove method again
### Testing
<!-- Please describe in detail how you tested your changes. -->
tested with building a wkwebview test app
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on pull request #715: (ios): fix regression in #656
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #715:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/715#issuecomment-639335122
As far as I can see the PR #656 just added the function in `src/ios/CDVWKInAppBrowser.m`. You can check that in 2706f3460d8f5e5a05d629711d24d7556b923ce0. So it did not revert all changes just this file which probably was a conflict.
@PDLMobileApps Could you please double check to make sure everything is correct?
Thanks everyone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab edited a comment on pull request #715: (ios): fix regression in #656
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #715:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/715#issuecomment-639330885
@NiklasMerz
Thanks for posting this PR.
But could you please check the previous PR for this fix:
It was changed 2 files . And your PR change only one file.
Please take a look into what was merged with this PR
https://github.com/apache/cordova-plugin-inappbrowser/pull/666/files
First file changes was:
src/ios/CDVInAppBrowserNavigationController.m
Changes was:
One line has been removed, One new line has been added, 10 lines has been removed.
Second file is:
src/ios/CDVWKInAppBrowser.m
Changes was:
One line has been removed, One new line has been added, 10 lines has been removed.
Just i post this to confirm if everything go in right way.
Regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab commented on pull request #715: (ios): fix regression in #656
Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #715:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/715#issuecomment-639330885
@NiklasMerz
Thanks for posting this pr again
but could you please check the previous PR for this fix:
It was changed 2 files . And your PR change only one file.
Please take a look into what was merged with this PR
https://github.com/apache/cordova-plugin-inappbrowser/pull/666/files
First file changes was:
src/ios/CDVInAppBrowserNavigationController.m
Changes was:
One line has been removed, One new line has been added, 10 lines has been removed.
deleted one line and added one line
Second file is:
src/ios/CDVWKInAppBrowser.m
Changes was:
One line has been removed, One new line has been added, 10 lines has been removed.
Regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab edited a comment on pull request #715: (ios): fix regression in #656
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #715:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/715#issuecomment-639330885
@NiklasMerz
Thanks for posting this PR.
But could you please check the previous PR for this fix:
It was changed 2 files . And your PR change only one file.
Please take a look into what was merged with this PR
https://github.com/apache/cordova-plugin-inappbrowser/pull/666/files
First file changes was:
src/ios/CDVInAppBrowserNavigationController.m
Changes was:
One line has been removed, One new line has been added, 10 lines has been removed.
Second file is:
src/ios/CDVWKInAppBrowser.m
Changes was:
One line has been removed, One new line has been added, 10 lines has been removed.
Just I post this to confirm if everything go in right way.
Regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz merged pull request #715: (ios): fix regression in #656
Posted by GitBox <gi...@apache.org>.
NiklasMerz merged pull request #715:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/715
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab edited a comment on pull request #715: (ios): fix regression in #656
Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #715:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/715#issuecomment-639330885
@NiklasMerz
Thanks for posting this pr again
but could you please check the previous PR for this fix:
It was changed 2 files . And your PR change only one file.
Please take a look into what was merged with this PR
https://github.com/apache/cordova-plugin-inappbrowser/pull/666/files
First file changes was:
src/ios/CDVInAppBrowserNavigationController.m
Changes was:
One line has been removed, One new line has been added, 10 lines has been removed.
deleted one line and added one line
Second file is:
src/ios/CDVWKInAppBrowser.m
Changes was:
One line has been removed, One new line has been added, 10 lines has been removed.
Just i post this to confirm if everything go in right way.
Regards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org