You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/07 16:07:07 UTC

[GitHub] [airflow] mik-laj commented on pull request #9943: Increase typing coverage for postgres provider

mik-laj commented on pull request #9943:
URL: https://github.com/apache/airflow/pull/9943#issuecomment-670591261


   @kenjihiraoka Parameter ``conn`` in ``DbApiHook`` is set to a default value when it really should always be passed. The following change should fix this problem.
   ```
   --- a/airflow/hooks/dbapi_hook.py
   +++ b/airflow/hooks/dbapi_hook.py
   @@ -307,7 +307,7 @@ class DbApiHook(BaseHook):
            self.log.info("Done loading. Loaded a total of %s rows", i)
   
        @staticmethod
   -    def _serialize_cell(cell: Any, conn: Any = None) -> Any:  # pylint: disable=unused-argument
   +    def _serialize_cell(cell, conn):  # pylint: disable=unused-argument
            """
            Returns the SQL literal of the cell as a string.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org