You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/10 06:26:46 UTC

[GitHub] [pulsar] hangc0276 opened a new pull request #6705: expose managedLedgerCache, managedLedger, loadBalance metrics to prometheus

hangc0276 opened a new pull request #6705: expose managedLedgerCache, managedLedger, loadBalance metrics to prometheus
URL: https://github.com/apache/pulsar/pull/6705
 
 
   ### Motivation
   The managed ledger read cache monitor metric is export via /admin/broker-stats/metrics with json format, it is hard to parse, collect and display, what's more the read cache is a very import module for message consuming throughput and latency. So collect and display the read cache metrics is extremely urgent for pulsar in production.
   
   ### Changes
   I parse the json format metric to prometheus message type and export to prometheus monitor port, so those metrics can be displayed in grafana.
   
   Please help check those changes, if it's ok, i will update the metric document.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] hangc0276 commented on issue #6705: expose managedLedgerCache, managedLedger, loadBalance metrics to prometheus

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on issue #6705: expose managedLedgerCache, managedLedger, loadBalance metrics to prometheus
URL: https://github.com/apache/pulsar/pull/6705#issuecomment-616072305
 
 
   I have updated the document and rebase the master branch, but it still run test case failed. Please help take a look @codelipenghui @sijie 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] hangc0276 commented on a change in pull request #6705: expose managedLedgerCache, managedLedger, loadBalance metrics to prometheus

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on a change in pull request #6705: expose managedLedgerCache, managedLedger, loadBalance metrics to prometheus
URL: https://github.com/apache/pulsar/pull/6705#discussion_r407128971
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java
 ##########
 @@ -20,10 +20,14 @@
 
 import java.io.IOException;
 import java.io.OutputStream;
-import java.util.Enumeration;
+import java.util.*;
 
 Review comment:
   ok，i will update in next commit with metric document.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #6705: expose managedLedgerCache, managedLedger, loadBalance metrics to prometheus

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6705: expose managedLedgerCache, managedLedger, loadBalance metrics to prometheus
URL: https://github.com/apache/pulsar/pull/6705#issuecomment-612792155
 
 
   @hangc0276 You'd better rebase the branch with master since there are some fixes related to integration tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on a change in pull request #6705: expose managedLedgerCache, managedLedger, loadBalance metrics to prometheus

Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #6705: expose managedLedgerCache, managedLedger, loadBalance metrics to prometheus
URL: https://github.com/apache/pulsar/pull/6705#discussion_r407092829
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java
 ##########
 @@ -20,10 +20,14 @@
 
 import java.io.IOException;
 import java.io.OutputStream;
-import java.util.Enumeration;
+import java.util.*;
 
 Review comment:
   @hangc0276 can we avoid wildcard import?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services