You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by pe...@apache.org on 2021/12/02 13:39:09 UTC
[pulsar] branch master updated: Remove unused assign value in DefaultMessageFormatter (#12837)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 1f61c3e Remove unused assign value in DefaultMessageFormatter (#12837)
1f61c3e is described below
commit 1f61c3eae2b7cde8a7d844934fc202e0c586d124
Author: ZhangJian He <sh...@gmail.com>
AuthorDate: Thu Dec 2 21:38:07 2021 +0800
Remove unused assign value in DefaultMessageFormatter (#12837)
---
.../pulsar/testclient/DefaultMessageFormatter.java | 16 +++++-----------
.../pulsar/testclient/TestDefaultMessageFormatter.java | 2 +-
2 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java b/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java
index 897c90a..8264c7e 100644
--- a/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java
+++ b/pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java
@@ -18,11 +18,13 @@
*/
package org.apache.pulsar.testclient;
+import org.apache.commons.lang3.RandomStringUtils;
+
import java.nio.charset.StandardCharsets;
import java.util.Random;
public class DefaultMessageFormatter implements IMessageFormatter {
- Random r = new Random();
+ private final Random r = new Random();
@Override
@@ -80,22 +82,14 @@ public class DefaultMessageFormatter implements IMessageFormatter {
}
private String getStringValue(float size) {
- int s = (int) size;
- if (size == 0) {
- size = 20;
- }
- String result = "";
- for(int i = 0; i < s; i++) {
- result = result + (char) ((int) 'a' + (int) (r.nextFloat() * 26));
- }
- return result;
+ return RandomStringUtils.randomAlphabetic((int) size);
}
private String getFloatValue(float size) {
if (size == 0) {
return String.valueOf(r.nextFloat());
}
- String format = "%" + String.valueOf(size) + "f";
+ String format = "%" + size + "f";
return String.format(format, _getFloatValue(size));
}
diff --git a/pulsar-testclient/src/test/java/org/apache/pulsar/testclient/TestDefaultMessageFormatter.java b/pulsar-testclient/src/test/java/org/apache/pulsar/testclient/TestDefaultMessageFormatter.java
index 785b88b..f1410e6 100644
--- a/pulsar-testclient/src/test/java/org/apache/pulsar/testclient/TestDefaultMessageFormatter.java
+++ b/pulsar-testclient/src/test/java/org/apache/pulsar/testclient/TestDefaultMessageFormatter.java
@@ -68,6 +68,6 @@ public class TestDefaultMessageFormatter {
Assert.assertTrue(0 < i2, "i2 was " + i2);
Assert.assertTrue(f2 < 100000);
Assert.assertTrue( -100000 < f2);
-
}
+
}