You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "gabotorresruiz (via GitHub)" <gi...@apache.org> on 2026/09/15 15:31:45 UTC

[PR] fix(embedded): report content height independent of iframe height [superset]

gabotorresruiz opened a new pull request, #44313:
URL: https://github.com/apache/superset/pull/44313

   ### SUMMARY
   
   A host embedding a dashboard cannot know how tall the content is, so the pattern our embedding docs publish asks the dashboard via `getScrollSize()` and sizes the iframe from the answer.
   That loop only terminates if the answer is independent of the iframe height, and it was not.
   
   Two things made the reported height a function of the frame:
   
   - The app fills its frame by design, so measuring `document.body.scrollHeight` returned the height the host had just set.
   - The vertical filter bar sized its scroll area from `calc(100vh - offset)`, which inside an iframe is the iframe's own height, and the Apply and Clear buttons sat **after** that scroll area rather than inside it.
   
   The reported height was therefore always `frame + constant`, so a host applying it grew the iframe on every poll, without bound and without decay.
   The same root cause has a second, user visible symptom: because the panel stretched to the full frame, the filter list stopped scrolling inside its own panel and the action buttons followed the frame to the bottom, far outside what the viewer could see.
   
   #### Approach
   
   - `getScrollSize()` lifts the fill the frame constraint for a single synchronous read, so it describes the content rather than handing the frame back. Inline styles are used deliberately: a stylesheet rule has to win a specificity contest, and losing it silently turns the call back into a measurement of the frame.
   - Before the dashboard lays out there is nothing to measure, so it reports the viewport. A host applying a near zero height would collapse the embed, and charts only render once they are in view, so it could not recover.
   - In an embed the filter bar becomes a bounded flex column, as tall as its content but never taller than the frame. The filter list is the only part that scrolls, so the header and the buttons stay inside the panel.
   - `VersionHistoryColumn` no longer renders in embeds. It is sized from `100vh`, renders empty for guests, and pinned the document height to the frame.
   - Separately, the dashboard header was capped with `max-width: calc(100vw - filterBarWidth)`. Viewport units include the scrollbar gutter, so with classic scrollbars the header ran past the visible edge and **every** dashboard with the filter bar open scrolled horizontally by the width of the scrollbar. The grid track already knows its own width.
   
   #### Known limitation
   
   With a frame larger than the content the buttons are no longer pinned to the visible area, because a guest document cannot know which part of itself the host has on screen.
   Their distance is now bounded by the content height rather than the iframe height, which is the part that used to scale without limit.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Measured with a 746px browser window on a dashboard with 12 native filters and a vertical filter bar.
   
   | | before | after |
   |---|---|---|
   | Reported height at an 800px frame | 1665 | 1665 |
   | Reported height at a 2400px frame | 2400 | **1665** |
   | Documented resize loop, per tick delta | `+40` forever, no decay | `0` after two ticks |
   | Apply filters in a 4000px frame | 3908px down | **1045px** down |
   | Apply filters in a 6000px frame | tracks the frame | **1045px** down, capped |
   | Fit to window, document vs frame | 785 vs 767 | 767 vs 767 |
   | Horizontal overflow, filter bar open | 15px | 0 |
   
   Reported height is identical at ten frame sizes from 400 to 6000.
   
   ### TESTING INSTRUCTIONS
   
   Automated, added in this PR:
   
   ```bash
   cd superset-frontend
   INCLUDE_EMBEDDED=true npx playwright test playwright/tests/embedded/embedded-iframe-sizing.spec.ts --project=chromium-embedded
   ```
   
   Four tests, all of which run against the existing embedded test app:
   
   1. `reported content height does not depend on the iframe height`
   2. `the documented resize loop settles instead of growing`
   3. `measuring the content leaves no inline styles behind`
   4. `a frame taller than the window keeps the content at the top`
   
   On `master` the first two fail with exactly the reported signature:
   
   ```
   reported content height does not depend on the iframe height
     Expected: 1665
     Received: 2400
   
   the documented resize loop settles instead of growing
     Expected  [0, 0, 0]
     Received  [40, 40, 40]
   ```
   
   Note that the second one reproduces on the `world_health` example dashboard, which has **no** vertical filter bar.
   The loop runs away purely because the reported height follows the frame and hosts add headroom of their own.
   
   Manual:
   
   1. Embed a dashboard with a vertical filter bar and several filters.
   2. Poll `handle.getScrollSize()` on an interval and apply the returned height to the iframe. The iframe should settle within a couple of ticks and stay there. Leave it running for two minutes to be sure.
   3. Set the iframe to a fixed 4000px. Apply filters should sit just below the last filter rather than at the bottom of the frame.
   4. Bind the iframe to the browser window. The filter list should scroll inside its own panel with the buttons pinned at the bottom of the panel.
   5. Open any dashboard normally with the filter bar open and confirm there is no horizontal scrollbar.
   
   Verified in Chromium, WebKit and Firefox, on dashboards with 12 filters, 2 filters and a horizontal filter bar, in edit mode, in standalone modes 1, 2 and 3, and at phone width with mobile consumption mode enabled.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   #### Review guidance
   
   The riskiest hunk is the `StyledHeader` change in `DashboardBuilder.tsx`, because it is the only one that affects **every** dashboard rather than embeds alone.
   Everything else is gated on `isEmbedded()`, so a non embedded dashboard renders byte identical CSS.
   
   Suggested reading order:
   
   1. `src/embedded/api.tsx`, the measurement itself.
   2. `FilterBar/Vertical.tsx`, the bounded bar.
   3. `DashboardBuilder.tsx`, the version history guard, the column separator, and the header cap.
   4. The new spec.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): report content height independent of iframe height [superset]

Posted by "gabotorresruiz (via GitHub)" <gi...@apache.org>.
gabotorresruiz commented on PR #44313:
URL: https://github.com/apache/superset/pull/44313#issuecomment-5702566636

   Thanks @rebenitez1802 for the review. Addressed in 1dcf1e5a85: dropped the dead `currentFilterBarWidth` state and its render-time setter, added `isEmbedded`-mocked tests for the version-history suppression and the panel separator, and moved `createAdminContext`, the origin derivation and the SDK-bundle skip into `embeddedAppServer.ts` so all three embedded specs share them. Kept the three header tests as they are: each pins the invariant for a distinct filter-bar state, and the names read better than one parameterized case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): report content height independent of iframe height [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44313:
URL: https://github.com/apache/superset/pull/44313#issuecomment-5704853013

   **Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): report content height independent of iframe height [superset]

Posted by "gabotorresruiz (via GitHub)" <gi...@apache.org>.
gabotorresruiz commented on code in PR #44313:
URL: https://github.com/apache/superset/pull/44313#discussion_r4029926320


##########
superset-frontend/src/embedded/api.tsx:
##########
@@ -46,10 +46,55 @@ type EmbeddedSupersetApi = {
   setDataMask: ({ dataMask }: { dataMask: DataMaskStateWithId }) => void;
 };
 
-const getScrollSize = (): Size => ({
-  width: document.body.scrollWidth,
-  height: document.body.scrollHeight,
-});
+// Hosts size the iframe from this value, so it has to describe the content and
+// not the frame the host already set. Lift the fill-the-frame constraints, read,
+// restore, all in one synchronous task. The styles are set inline so they win
+// the cascade outright: a rule that silently loses it turns this back into a
+// measurement of the frame.
+const getScrollSize = (): Size => {
+  const root = document.documentElement;
+  const { body } = document;
+  const app = document.getElementById('app');
+  const content = document.querySelector('#app .dashboard');
+
+  // Nothing has laid out yet, so report the viewport. A host applying a near
+  // zero height would collapse the frame, and charts render only once they are
+  // in view, so the embed could not recover.
+  if (!content || content.getBoundingClientRect().height === 0) {

Review Comment:
   Good catch — fixed in 1cae80c1ac. The guard now gates on the store having hydrated (`dashboardInfo.id`) plus `.dashboard-grid` being in the DOM, rather than on the container having any height. The grid’s rows take their heights from the layout, not from chart data, so once it is mounted the measurement is complete even while charts are still loading, and the partial-layout window you describe no longer passes the guard. Two unit tests cover it, both using a 120px chrome-only height that the old check would have let through: one for “not hydrated”, one for “hydrated but grid not mounted”.



##########
superset-frontend/src/embedded/api.tsx:
##########
@@ -46,10 +46,55 @@ type EmbeddedSupersetApi = {
   setDataMask: ({ dataMask }: { dataMask: DataMaskStateWithId }) => void;
 };
 
-const getScrollSize = (): Size => ({
-  width: document.body.scrollWidth,
-  height: document.body.scrollHeight,
-});
+// Hosts size the iframe from this value, so it has to describe the content and
+// not the frame the host already set. Lift the fill-the-frame constraints, read,
+// restore, all in one synchronous task. The styles are set inline so they win
+// the cascade outright: a rule that silently loses it turns this back into a
+// measurement of the frame.
+const getScrollSize = (): Size => {
+  const root = document.documentElement;
+  const { body } = document;
+  const app = document.getElementById('app');
+  const content = document.querySelector('#app .dashboard');
+
+  // Nothing has laid out yet, so report the viewport. A host applying a near
+  // zero height would collapse the frame, and charts render only once they are
+  // in view, so the embed could not recover.
+  if (!content || content.getBoundingClientRect().height === 0) {
+    return { width: body.scrollWidth, height: root.clientHeight };
+  }
+
+  // The bounded filter bar is capped to the frame as well, so the cap comes off
+  // too or a tall filter list reports as frame-high.
+  const bar = document.querySelector<HTMLElement>('.filter-bar-bounded');
+  const scroller = bar?.querySelector<HTMLElement>('.filter-bar-scroll');

Review Comment:
   Fixed in 1cae80c1ac. The class names now live in `src/dashboard/util/embeddedLayout.ts` (`DASHBOARD_GRID_CLASS`, `FILTER_BAR_BOUNDED_CLASS`, `FILTER_BAR_SCROLL_CLASS`) and are imported by `Vertical.tsx`, `DashboardGrid.tsx`, `api.tsx` and the `api.test.ts` fixture, so a rename in the component now breaks the unit test instead of silently regressing production. The Playwright spec keeps its own literals on purpose: it runs against the real DOM, so it fails loudly either way.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): report content height independent of iframe height [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44313:
URL: https://github.com/apache/superset/pull/44313#issuecomment-5687171168

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | be2d181013a5ac7dfeb60abafb57c4026bab3e2f |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aa9a0fbfa08260008819563 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44313--superset-docs-preview.netlify.app](https://deploy-preview-44313--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ0MzEzLS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.6o9DjyBIwzTJLatbcmjddQvo-jHe5_s3tpofKYX2Odc)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctBDgIhDADAv_QssWqWsP7AZ5RtWUiEkooHNf59uc1lftBNax9wBzhBNGpbnt4p6lAzedm7fM9SozALu5KMqrhN25A2XJay5zEjS3_q58GzeqKVMMVEGK4eEUO4rIu_wf8A) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-44313--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): report content height independent of iframe height [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44313:
URL: https://github.com/apache/superset/pull/44313#issuecomment-5683095791

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): report content height independent of iframe height [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44313:
URL: https://github.com/apache/superset/pull/44313#issuecomment-5701951505

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers an incremental AI Review.
   - `/review full` - Manually triggers a full AI Review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): report content height independent of iframe height [superset]

Posted by "rebenitez1802 (via GitHub)" <gi...@apache.org>.
rebenitez1802 commented on code in PR #44313:
URL: https://github.com/apache/superset/pull/44313#discussion_r4029671007


##########
superset-frontend/src/embedded/api.tsx:
##########
@@ -46,10 +46,55 @@ type EmbeddedSupersetApi = {
   setDataMask: ({ dataMask }: { dataMask: DataMaskStateWithId }) => void;
 };
 
-const getScrollSize = (): Size => ({
-  width: document.body.scrollWidth,
-  height: document.body.scrollHeight,
-});
+// Hosts size the iframe from this value, so it has to describe the content and
+// not the frame the host already set. Lift the fill-the-frame constraints, read,
+// restore, all in one synchronous task. The styles are set inline so they win
+// the cascade outright: a rule that silently loses it turns this back into a
+// measurement of the frame.
+const getScrollSize = (): Size => {
+  const root = document.documentElement;
+  const { body } = document;
+  const app = document.getElementById('app');
+  const content = document.querySelector('#app .dashboard');
+
+  // Nothing has laid out yet, so report the viewport. A host applying a near
+  // zero height would collapse the frame, and charts render only once they are
+  // in view, so the embed could not recover.
+  if (!content || content.getBoundingClientRect().height === 0) {

Review Comment:
   Non-blocking robustness nit: this "nothing has laid out yet" guard only checks that `.dashboard` has non-zero height. But a mounted `.dashboard` already has height from its header/tabs while below-the-fold charts are still lazy-loading. If a host calls `getScrollSize` in that window, the guard is bypassed and `body.scrollHeight` reflects only the short pre-render layout — the host then shrinks the iframe, the below-fold charts never enter the viewport, never render, and the embed can't recover. That's the exact failure this guard warns about, just triggered by *partial* layout instead of *zero* layout. Could be worth gating on a readiness signal rather than height alone.



##########
superset-frontend/src/embedded/api.tsx:
##########
@@ -46,10 +46,55 @@ type EmbeddedSupersetApi = {
   setDataMask: ({ dataMask }: { dataMask: DataMaskStateWithId }) => void;
 };
 
-const getScrollSize = (): Size => ({
-  width: document.body.scrollWidth,
-  height: document.body.scrollHeight,
-});
+// Hosts size the iframe from this value, so it has to describe the content and
+// not the frame the host already set. Lift the fill-the-frame constraints, read,
+// restore, all in one synchronous task. The styles are set inline so they win
+// the cascade outright: a rule that silently loses it turns this back into a
+// measurement of the frame.
+const getScrollSize = (): Size => {
+  const root = document.documentElement;
+  const { body } = document;
+  const app = document.getElementById('app');
+  const content = document.querySelector('#app .dashboard');
+
+  // Nothing has laid out yet, so report the viewport. A host applying a near
+  // zero height would collapse the frame, and charts render only once they are
+  // in view, so the embed could not recover.
+  if (!content || content.getBoundingClientRect().height === 0) {
+    return { width: body.scrollWidth, height: root.clientHeight };
+  }
+
+  // The bounded filter bar is capped to the frame as well, so the cap comes off
+  // too or a tall filter list reports as frame-high.
+  const bar = document.querySelector<HTMLElement>('.filter-bar-bounded');
+  const scroller = bar?.querySelector<HTMLElement>('.filter-bar-scroll');

Review Comment:
   Non-blocking maintainability nit: this couples to the `.filter-bar-bounded` / `.filter-bar-scroll` class names emitted by `Vertical.tsx`, with no compile-time link. `api.test.ts` builds its own fixture DOM using those same string literals, so renaming the class in `Vertical.tsx` would silently regress production (scroll position no longer captured/restored on host resize) while the unit test stays green. A shared constant for the class names — or a test that renders the real component instead of a hand-built fixture — would make the coupling visible to CI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): report content height independent of iframe height [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44313:
URL: https://github.com/apache/superset/pull/44313#issuecomment-5688823997

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44313?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `93.33333%` with `3 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 80.25%. Comparing base ([`4c27cbd`](https://app.codecov.io/gh/apache/superset/commit/4c27cbd007efa298c2c1101b85a1ea158ed0502a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`def4b4e`](https://app.codecov.io/gh/apache/superset/commit/def4b4e8b68f670ef75cef0f701e7352fdab7bf0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/44313?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...rd/components/nativeFilters/FilterBar/Vertical.tsx](https://app.codecov.io/gh/apache/superset/pull/44313?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fdashboard%2Fcomponents%2FnativeFilters%2FFilterBar%2FVertical.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL1ZlcnRpY2FsLnRzeA==) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/44313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #44313   +/-   ##
   =======================================
     Coverage   80.25%   80.25%           
   =======================================
     Files        2927     2927           
     Lines      173166   173197   +31     
     Branches    40156    40169   +13     
   =======================================
   + Hits       138973   139000   +27     
   - Misses      31600    31604    +4     
     Partials     2593     2593           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/44313/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/44313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.68% <93.33%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44313?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(embedded): report content height independent of iframe height [superset]

Posted by "gabotorresruiz (via GitHub)" <gi...@apache.org>.
gabotorresruiz merged PR #44313:
URL: https://github.com/apache/superset/pull/44313


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org