You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/12 02:14:00 UTC

[GitHub] [arrow] rodrigojdebem opened a new pull request #10299: ARROW-12656: [C++][Gandiva] Implement castVARCHAR for date, intervalDay and intervalYear

rodrigojdebem opened a new pull request #10299:
URL: https://github.com/apache/arrow/pull/10299


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pprudhvi commented on pull request #10299: ARROW-12656: [C++][Gandiva] Implement castVARCHAR for date, intervalDay and intervalYear

Posted by GitBox <gi...@apache.org>.
pprudhvi commented on pull request #10299:
URL: https://github.com/apache/arrow/pull/10299#issuecomment-841710929


   castVARCHAR_intervalyear is missing, could you please add the impl or edit the commit message above?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10299: ARROW-12656: [C++][Gandiva] Implement castVARCHAR for date, intervalDay and intervalYear

Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on a change in pull request #10299:
URL: https://github.com/apache/arrow/pull/10299#discussion_r797948999



##########
File path: cpp/src/gandiva/function_registry_datetime.cc
##########
@@ -65,8 +65,16 @@ std::vector<NativeFunction> GetDateTimeFunctionRegistry() {
                      kResultNullIfNull, "castTIMESTAMP_utf8",
                      NativeFunction::kNeedsContext | NativeFunction::kCanReturnErrors),
 
-      NativeFunction("castVARCHAR", {}, DataTypeVector{timestamp(), int64()}, utf8(),

Review comment:
       The error is due to this removed function




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] anthonylouisbsb commented on pull request #10299: ARROW-12656: [C++][Gandiva] Implement castVARCHAR for date, intervalDay and intervalYear

Posted by GitBox <gi...@apache.org>.
anthonylouisbsb commented on pull request #10299:
URL: https://github.com/apache/arrow/pull/10299#issuecomment-846344467


   I add in this PR the implementation for the `castVARCHAR(time, len)` function in Gandiva


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #10299: ARROW-12656: [C++][Gandiva] Implement castVARCHAR for date, intervalDay and intervalYear

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10299:
URL: https://github.com/apache/arrow/pull/10299#issuecomment-839379441


   https://issues.apache.org/jira/browse/ARROW-12656


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org