You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/10/25 18:53:08 UTC
[kudu-CR] Add krb5 dependency to Java README
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4840
to review the following change.
Change subject: Add krb5 dependency to Java README
......................................................................
Add krb5 dependency to Java README
I think it's a little premature to add it to installation.adoc, since it
isn't required for building or operating Kudu yet (it's a test-only
dependency).
Change-Id: I5e4ffe0bee242ddec3a9effd4c3404348f1b889c
---
M README.adoc
M java/README.md
2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/4840/1
--
To view, visit http://gerrit.cloudera.org:8080/4840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e4ffe0bee242ddec3a9effd4c3404348f1b889c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] Add krb5 dependency to Java README
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Add krb5 dependency to Java README
......................................................................
Add krb5 dependency to Java README
I think it's a little premature to add it to installation.adoc, since it
isn't required for building or operating Kudu yet (it's a test-only
dependency).
Change-Id: I5e4ffe0bee242ddec3a9effd4c3404348f1b889c
Reviewed-on: http://gerrit.cloudera.org:8080/4840
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Dan Burkert <da...@apache.org>
---
M README.adoc
M java/README.md
2 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Dan Burkert: Verified
Jean-Daniel Cryans: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e4ffe0bee242ddec3a9effd4c3404348f1b889c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add krb5 dependency to Java README
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Add krb5 dependency to Java README
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4ffe0bee242ddec3a9effd4c3404348f1b889c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Add krb5 dependency to Java README
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Add krb5 dependency to Java README
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e4ffe0bee242ddec3a9effd4c3404348f1b889c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No