You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tshauck (via GitHub)" <gi...@apache.org> on 2024/03/28 16:04:57 UTC
[PR] feat: pass SessionState not SessionConfig to FunctionFactory::create [arrow-datafusion]
tshauck opened a new pull request, #9837:
URL: https://github.com/apache/arrow-datafusion/pull/9837
## Which issue does this PR close?
Closes #.
## Rationale for this change
Right now `FunctionFactory::create` takes a `&SessionConfig` and not a `&SessionState`. This limits some of its utility and makes it currently out of line with at least `TableProviderFactory`, which takes a `&SessionState` as well.
## What changes are included in this PR?
Update the trait signature for `FunctionFactory::create` so that gets passed `&SessionState`.
## Are these changes tested?
Existing tests around `FunctionFactory` are mostly unchanged.
## Are there any user-facing changes?
Users of `FunctionFactory` will have to update their code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: pass SessionState not SessionConfig to FunctionFactory::create [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9837:
URL: https://github.com/apache/arrow-datafusion/pull/9837#issuecomment-2026077200
> not sure whats the status with datafusion v.37 release (#9682) , will this PR make it?
Yes, this shoudl make 37.0.0 I think. I'll plan to make a release tomorrow
I am not sure either -- going to https://github.com/apache/arrow-datafusion/issues/9682#issuecomment-2026074429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: pass SessionState not SessionConfig to FunctionFactory::create [arrow-datafusion]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on PR #9837:
URL: https://github.com/apache/arrow-datafusion/pull/9837#issuecomment-2026036088
not sure whats the status with datafusion v.37 release (#9682) , will this PR make it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: pass SessionState not SessionConfig to FunctionFactory::create [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #9837:
URL: https://github.com/apache/arrow-datafusion/pull/9837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: pass SessionState not SessionConfig to FunctionFactory::create [arrow-datafusion]
Posted by "milenkovicm (via GitHub)" <gi...@apache.org>.
milenkovicm commented on PR #9837:
URL: https://github.com/apache/arrow-datafusion/pull/9837#issuecomment-2025911298
I would agree with @tshauck, it was my omission rather than intention. It probably slipped while I was trying to remove locking from my first commit.
thank you @tshauck & @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: pass SessionState not SessionConfig to FunctionFactory::create [arrow-datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9837:
URL: https://github.com/apache/arrow-datafusion/pull/9837#issuecomment-2025824436
Thank you (as always) @tshauck for the clear description and code @tshauck 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: pass SessionState not SessionConfig to FunctionFactory::create [arrow-datafusion]
Posted by "tshauck (via GitHub)" <gi...@apache.org>.
tshauck commented on PR #9837:
URL: https://github.com/apache/arrow-datafusion/pull/9837#issuecomment-2026085377
Thanks @alamb, thanks @milenkovicm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org