You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/02 12:05:53 UTC

[GitHub] [calcite] jinxing64 opened a new pull request #1716: [CALCITE-3593] RelToSqlConverter fails to wrap a new SqlSelect for HAVING clause when isHavingAlias is true 

jinxing64 opened a new pull request #1716: [CALCITE-3593] RelToSqlConverter fails to wrap a new SqlSelect for HAVING clause when isHavingAlias is true 
URL: https://github.com/apache/calcite/pull/1716
 
 
   …

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] xy2953396112 commented on a change in pull request #1716: [CALCITE-3593] RelToSqlConverter fails to wrap a new SqlSelect for HAVING clause when isHavingAlias is true

Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on a change in pull request #1716: [CALCITE-3593] RelToSqlConverter fails to wrap a new SqlSelect for HAVING clause when isHavingAlias is true 
URL: https://github.com/apache/calcite/pull/1716#discussion_r362743142
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/sql/dialect/BigQuerySqlDialect.java
 ##########
 @@ -192,6 +194,14 @@ public BigQuerySqlDialect(SqlDialect.Context context) {
     }
   }
 
+  @Override public SqlConformance getConformance() {
+    return new SqlAbstractConformance() {
+      @Override public boolean isHavingAlias() {
 
 Review comment:
   only for BigQuerySqlDialect ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] asfgit closed pull request #1716: [CALCITE-3593] RelToSqlConverter fails to wrap a new SqlSelect for HAVING clause when isHavingAlias is true

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1716: [CALCITE-3593] RelToSqlConverter fails to wrap a new SqlSelect for HAVING clause when isHavingAlias is true 
URL: https://github.com/apache/calcite/pull/1716
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services