[GitHub] [airflow] potiuk commented on a diff in pull request #34042: AIP44 Fix DAG serialization

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on code in PR #34042:
URL: https://github.com/apache/airflow/pull/34042#discussion_r1315218517


##########
airflow/serialization/serialized_objects.py:
##########
@@ -438,7 +438,7 @@ def serialize(
             json_pod = PodGenerator.serialize_pod(var)
             return cls._encode(json_pod, type_=DAT.POD)
         elif isinstance(var, DAG):
-            return SerializedDAG.serialize_dag(var)
+            return cls._encode(SerializedDAG.serialize_dag(var), type_=DAT.DAG)

Review Comment:
   Yeah. I think @mhenc is right - this part of code seems to be not used before - it's not 'DAG` serialization that gets afffected here, it's just serializing the whole `dag` s part of bigger structure. I have not seen any place in the code where we'd do that before.



##########
airflow/serialization/serialized_objects.py:
##########
@@ -438,7 +438,7 @@ def serialize(
             json_pod = PodGenerator.serialize_pod(var)
             return cls._encode(json_pod, type_=DAT.POD)
         elif isinstance(var, DAG):
-            return SerializedDAG.serialize_dag(var)
+            return cls._encode(SerializedDAG.serialize_dag(var), type_=DAT.DAG)

Review Comment:
   Yeah. I think @mhenc is right - this part of code seems to be not used before - it's not `DAG` serialization that gets afffected here, it's just serializing the whole `dag` s part of bigger structure. I have not seen any place in the code where we'd do that before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org