You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by tushargosavi <gi...@git.apache.org> on 2015/12/09 11:35:17 UTC
[GitHub] incubator-apex-malhar pull request: MLHR-1901 #resolve
GitHub user tushargosavi opened a pull request:
https://github.com/apache/incubator-apex-malhar/pull/121
MLHR-1901 #resolve
Changed location of the directory where test files were generated.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tushargosavi/incubator-apex-malhar MLHR-1901
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-malhar/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit dd73ffd59ba18c5812314935a62a6121c49056ac
Author: Tushar R. Gosavi <tu...@apache.org>
Date: 2015-12-09T10:19:33Z
MLHR-1901 #resolve
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: MLHR-1901 #resolve
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-malhar/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: MLHR-1901 #resolve
Posted by chandnisingh <gi...@git.apache.org>.
Github user chandnisingh commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/121#discussion_r47169882
--- Diff: library/src/test/java/org/apache/hadoop/io/file/tfile/DTFileTest.java ---
@@ -70,7 +73,7 @@ public void setUp() throws IOException
conf.setInt("tfile.fs.input.buffer.size", tconf.fsInputBufferSize);
conf.setInt("tfile.fs.output.buffer.size", tconf.fsOutputBufferSize);
- path = new Path("tmp/dtfile");
+ path = new Path(ROOT, "/tmp/dtfile");
--- End diff --
@tushargosavi we usually create any test data files under target directory
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-malhar pull request: MLHR-1901 #resolve
Posted by tushargosavi <gi...@git.apache.org>.
Github user tushargosavi commented on a diff in the pull request:
https://github.com/apache/incubator-apex-malhar/pull/121#discussion_r47189655
--- Diff: library/src/test/java/org/apache/hadoop/io/file/tfile/DTFileTest.java ---
@@ -70,7 +73,7 @@ public void setUp() throws IOException
conf.setInt("tfile.fs.input.buffer.size", tconf.fsInputBufferSize);
conf.setInt("tfile.fs.output.buffer.size", tconf.fsOutputBufferSize);
- path = new Path("tmp/dtfile");
+ path = new Path(ROOT, "/tmp/dtfile");
--- End diff --
@chandnisingh other tests in tfile using same pattern. I used the same path for consistency. This code was copied from apache tfile implementation. Do you want all tests to use target directory for test data?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---