You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/08 08:59:22 UTC
[GitHub] [superset] razzius opened a new issue #13959: Annotation background is transparent, causing text to overlap illegibly
razzius opened a new issue #13959:
URL: https://github.com/apache/superset/issues/13959
## Screenshot
<img width="280" alt="image" src="https://user-images.githubusercontent.com/2244895/113651255-80571580-9646-11eb-8929-63adf6d66903.png">
## Description
Annotations of type "interval", when added to a line chart, show up directly on top of the chart / legend, causing text to overlap in a way that makes it hard to read. I think in the past (pre-1.0) there was an opaque background that made annotations legible.
## Design input
Anything that makes the text legible would be welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] razzius closed issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
razzius closed issue #13959:
URL: https://github.com/apache/superset/issues/13959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] razzius closed issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
razzius closed issue #13959:
URL: https://github.com/apache/superset/issues/13959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] razzius commented on issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
razzius commented on issue #13959:
URL: https://github.com/apache/superset/issues/13959#issuecomment-959815144
Looks like this has been fixed since 1.3. Closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] razzius closed issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
razzius closed issue #13959:
URL: https://github.com/apache/superset/issues/13959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] razzius commented on issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
razzius commented on issue #13959:
URL: https://github.com/apache/superset/issues/13959#issuecomment-815037486
@junlincc it looks like the controls customize how the overlay on the graph shows up (at least this is the case with color, see screenshot), not the annotation text. Opacity doesn't seem to have any effect, though, so perhaps something strange is going on with that.
<img width="364" alt="image" src="https://user-images.githubusercontent.com/2244895/113898473-c57f6280-9780-11eb-9c72-75de55051886.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #13959:
URL: https://github.com/apache/superset/issues/13959#issuecomment-814703726
I believe users can set the opacity of annotation. can you double check? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] razzius commented on issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
razzius commented on issue #13959:
URL: https://github.com/apache/superset/issues/13959#issuecomment-959815144
Looks like this has been fixed since 1.3. Closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] bwgroff commented on issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
bwgroff commented on issue #13959:
URL: https://github.com/apache/superset/issues/13959#issuecomment-839815212
I've looked all over and the only controls for transparency I can find are the ones governing the rectangular chart overlay, nothing about the box containing the annotation description.
cc @junlincc @razzius
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] razzius edited a comment on issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
razzius edited a comment on issue #13959:
URL: https://github.com/apache/superset/issues/13959#issuecomment-988610265
This is still an issue actually, tested on `master` branch just now (cd88b8e81ea3721f93d0cfdd0329f380a2c3d061). I was confusing annotations with the rectangular chart overlay when I closed this.
Steps to reproduce:
- Get source code
`git clone https://github.com/apache/superset`
- Run superset in docker
- This should load the sample data, but time series chart will do
`docker-compose -f docker-compose-non-dev.yml up`
- Log in as admin/admin at localhost:8088
- Hover over settings in top right; under "Manage" click "Annotation Layers"
- Click "+ ANNOTATION LAYER", give it a name, click "ADD" to create it
- Click "+ ANNOTATION", give it a name, a start date, and an end date (for example make your annotation named "Test annotation" and make it start January 1 2010 and end December 31 2016). Click "ADD" to create it
- Navigate to a sample chart that has a time axis, such as "Games per Genre over time"
- Click "+ Add annotation layer" at the bottom of the column with the chart configuration
- Give it a name, change ANNOTATION LAYER TYPE to Event, select "Superset annotation" from ANNOTATION SOURCE, and select your annotation from ANNOTATION LAYER. Click OK
In the screenshot below, the issue is visible, namely that the name and description of the annotation do not have an opaque background and overlap with the chart legend. There is also the mouse hover tooltip which shows anywhere the mouse hovers over the chart, which overlaps as well.
(It appears there is a new issue now as well, namely that the annotation is only showing as a single vertical line, when it should show as a time range overlaying the chart.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] razzius commented on issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
razzius commented on issue #13959:
URL: https://github.com/apache/superset/issues/13959#issuecomment-959815144
Looks like this has been fixed since 1.3. Closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] razzius closed issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
razzius closed issue #13959:
URL: https://github.com/apache/superset/issues/13959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] razzius commented on issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
razzius commented on issue #13959:
URL: https://github.com/apache/superset/issues/13959#issuecomment-959815144
Looks like this has been fixed since 1.3. Closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] razzius commented on issue #13959: Annotation background is transparent, causing text to overlap illegibly
Posted by GitBox <gi...@apache.org>.
razzius commented on issue #13959:
URL: https://github.com/apache/superset/issues/13959#issuecomment-988610265
This is still an issue actually, tested on `master` branch just now (cd88b8e81ea3721f93d0cfdd0329f380a2c3d061). I was confusing annotations with the rectangular chart overlay when I closed this.
Steps to reproduce:
- Get source code
git clone https://github.com/apache/superset
- Run superset in docker
docker-compose -f docker-compose-non-dev.yml up
- Log in as admin/admin at localhost:8088
open http://localhost:8088
- Hover over settings in top right; under "Manage" click "Annotation Layers"
- Click "+ ANNOTATION LAYER", give it a name, click "ADD" to create it
- Click "+ ANNOTATION"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org