You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Quanlong Huang (Jira)" <ji...@apache.org> on 2020/09/01 08:10:00 UTC
[jira] [Commented] (IMPALA-9870) summary and profile command in
impala-shell should show both original and retried info
[ https://issues.apache.org/jira/browse/IMPALA-9870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17188243#comment-17188243 ]
Quanlong Huang commented on IMPALA-9870:
----------------------------------------
I think returning two profiles or summaries is incompactible. Some tools may rely on parsing one profile. What about extending the "summary" and "profile" commands by adding an optional "ALL/LATEST/ORIGINAL" argument? So the syntax is
{code:java}
SUMMARY [ALL | LATEST | ORIGINAL]
PROFILE [ALL | LATEST | ORIGINAL] {code}
* If "ALL" is specified, the client will get both the original and the retried results.
* If "LATEST" is specified, the client will get the result of the last attemp, which is the retried query if the original query failed. No difference for non-retried queries.
* If "ORIGINAL" is specified, the client will get the result of the first attemp, which is the original query if it's retried. No difference for non-retried queries.
* If none of them are specified, defaults to "ORIGINAL"
I think there are two ways to do this, depending on where we put the logic - client side or server side.
# If we do this on client sides, we can retrun the retried query id in TExecSummary. Clients (e.g. impala-shell) can parse the argument and fetch what they need and stitch the results.
# If we do this on the server side, we need to extend TExecSummary to contain an optional latest summary. Profiles are returned as strings so no changes on the thrift definitions. Clients should send the additional argument (ALL/LATEST/ORIGINAL) in GetExecSummary and GetRuntimeProfile calls. Coordinator should maintain a map from the original query id to the retried query id (if has) for lookup.
I prefer doing this on the client sides since it has less changes. On the other hand, SUMMARY and PROFILE are not defined in our SQL standard. Looks like just impala-shell supports them.
[~stakiar], any thoughts on this?
> summary and profile command in impala-shell should show both original and retried info
> --------------------------------------------------------------------------------------
>
> Key: IMPALA-9870
> URL: https://issues.apache.org/jira/browse/IMPALA-9870
> Project: IMPALA
> Issue Type: Sub-task
> Reporter: Quanlong Huang
> Assignee: Quanlong Huang
> Priority: Major
>
> If a query is retried, impala-shell still uses the original query handle containing the original query id. Subsequent "summary" and "profile" commands will return results of the original query. We should consider return both the original and retried information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org