You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/12 08:25:33 UTC
[GitHub] [skywalking-cli] fgksgf opened a new pull request #55: Integrated the heat map into the `dashboard global` command
fgksgf opened a new pull request #55:
URL: https://github.com/apache/skywalking-cli/pull/55
Because I re-implemented the heat map widget with `termdash`, the amount of code submitted this time is large. So I only integrated the heat map into `dashboard global` command this time, and didn't modify the `metrics thermodynamic` command.
Next, I will refactor the `metrics thermodynamic` command to adopt the new query protocol and the new heat map widget.
Here is a comparison of the two heat maps:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] wu-sheng commented on pull request #55: Integrated the heat map into the `dashboard global` command
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #55:
URL: https://github.com/apache/skywalking-cli/pull/55#issuecomment-673532771
The twitter belongs to you, https://twitter.com/ASFSkyWalking/status/1293926485254799361
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] kezhenxu94 merged pull request #55: Integrated the heat map into the `dashboard global` command
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #55:
URL: https://github.com/apache/skywalking-cli/pull/55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] kezhenxu94 commented on pull request #55: Integrated the heat map into the `dashboard global` command
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #55:
URL: https://github.com/apache/skywalking-cli/pull/55#issuecomment-672978274
> Because I re-implemented the heat map widget with `termdash`, the amount of code submitted this time is large. So I only integrated the heat map into `dashboard global` command this time, and didn't modify the `metrics thermodynamic` command.
Good choice
> Next PR, I will refactor the `metrics thermodynamic` command to adopt the new query protocol and the new heat map widget.
Replacing the old heat map widget and adopting new query protocol can be done in two individual PRs. Replacing widget needs to review whether the termui library is still in used or not, and remove it and its license if it's not used anymore
>
> Here is a comparison of the two heat maps:
>
> 
>
> 
Looks cool, will take a look at the codes soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org