You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eumiro (via GitHub)" <gi...@apache.org> on 2023/09/15 17:42:44 UTC

[GitHub] [airflow] eumiro opened a new pull request, #34402: Refactor: consolidate import time in providers

eumiro opened a new pull request, #34402:
URL: https://github.com/apache/airflow/pull/34402

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] vincbeck commented on pull request #34402: Refactor: consolidate import time in providers

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #34402:
URL: https://github.com/apache/airflow/pull/34402#issuecomment-1735516806

   Conflicts


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor: consolidate import time in providers [airflow]

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #34402:
URL: https://github.com/apache/airflow/pull/34402


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor: consolidate import time in providers [airflow]

Posted by "eumiro (via GitHub)" <gi...@apache.org>.
eumiro commented on PR #34402:
URL: https://github.com/apache/airflow/pull/34402#issuecomment-1751944675

   > Why doing this change? Why is it better?
   
   It was to have the same import of time everywhere in the repo. `import time` and `from time import time` makes it confusing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor: consolidate import time in providers [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on PR #34402:
URL: https://github.com/apache/airflow/pull/34402#issuecomment-1746083876

   I guess the motivation is to unify how we import `time` into airflow. I found `import time` is used more frequently than `from time import sleep`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] vincbeck commented on pull request #34402: Refactor: consolidate import time in providers

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #34402:
URL: https://github.com/apache/airflow/pull/34402#issuecomment-1739419040

   Why doing this change? Why is it better?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] o-nikolas commented on pull request #34402: Refactor: consolidate import time in providers

Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #34402:
URL: https://github.com/apache/airflow/pull/34402#issuecomment-1739825091

   > Why doing this change? Why is it better?
   
   I agree, I especially don't like PRs with zero description. What is the motivation here? Any links to resources that explain why this is a best practice? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org