You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StefanRRichter <gi...@git.apache.org> on 2017/07/03 09:48:47 UTC

[GitHub] flink pull request #4246: [FLINK-7063] [checkpoint] Call super.cancel(...) b...

GitHub user StefanRRichter opened a pull request:

    https://github.com/apache/flink/pull/4246

    [FLINK-7063] [checkpoint] Call super.cancel(...) before closing strea…

    Minor fix that has only consequences in exception reporting. With this change, the future is first set to canceled state before a potential IO exception due to the closed stream can be reported first.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StefanRRichter/flink FLINK-7063

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4246.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4246
    
----
commit 9116129aec71937bf73e8c2ae727c164fdb95297
Author: Stefan Richter <s....@data-artisans.com>
Date:   2017-07-03T09:46:16Z

    [FLINK-7063] [checkpoint] Call super.cancel(...) before closing streams in AsyncStoppableTaskWithCallback

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4246: [FLINK-7063] [checkpoint] Call super.cancel(...) b...

Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter closed the pull request at:

    https://github.com/apache/flink/pull/4246


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4246: [FLINK-7063] [checkpoint] Call super.cancel(...) before c...

Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/4246
  
    Thanks for the review @NicoK !
    
    Merged in 74adb84742.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4246: [FLINK-7063] [checkpoint] Call super.cancel(...) before c...

Posted by StefanRRichter <gi...@git.apache.org>.
Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/4246
  
    CC @NicoK 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4246: [FLINK-7063] [checkpoint] Call super.cancel(...) b...

Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4246#discussion_r126437776
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/async/AsyncStoppableTaskWithCallback.java ---
    @@ -21,6 +21,7 @@
     import org.apache.flink.util.Preconditions;
     
     import java.util.concurrent.FutureTask;
    +import java.util.concurrent.atomic.AtomicBoolean;
    --- End diff --
    
    unnecessary import


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---