You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/06/20 06:17:30 UTC
[GitHub] [cordova-android] erisu opened a new pull request, #1443: fix: force hostname to lowercase
erisu opened a new pull request, #1443:
URL: https://github.com/apache/cordova-android/pull/1443
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Fixes #1426
Per comment https://github.com/apache/cordova-android/issues/1426#issuecomment-1111661474
There might be an underlining issue within the Android WebView and how it is not honouring the domain name incase sensitive specification.
### Description
<!-- Describe your changes in detail -->
As workaround, this PR will force the user defined `hostname` to lowercase with the `.toLowerCase()` method.
### Testing
<!-- Please describe in detail how you tested your changes. -->
- `cordova build`
- `cordova run`
Also tested use cases where upper-case string could have been provided while we force lowercase.
**Html**
```
<a href="https://ABCDEFG/another-page.html">ANOTHER PAGE</a>
```
**Javascript**
```
window.location = "https://ABCDEFG/another-page.html";
```
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1443: fix: force hostname to lowercase
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1443:
URL: https://github.com/apache/cordova-android/pull/1443#issuecomment-1160021233
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1443?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1443](https://codecov.io/gh/apache/cordova-android/pull/1443?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f74ae8) into [master](https://codecov.io/gh/apache/cordova-android/commit/68a9a3181aae6e39d6812222087456358b8b377e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68a9a31) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1443 +/- ##
=======================================
Coverage 75.96% 75.96%
=======================================
Files 21 21
Lines 1677 1677
=======================================
Hits 1274 1274
Misses 403 403
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1443?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1443?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68a9a31...1f74ae8](https://codecov.io/gh/apache/cordova-android/pull/1443?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1443: fix: force hostname to lowercase
Posted by GitBox <gi...@apache.org>.
erisu merged PR #1443:
URL: https://github.com/apache/cordova-android/pull/1443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org