You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by nikhilkh <gi...@git.apache.org> on 2016/03/09 20:17:46 UTC
[GitHub] cordova-docs pull request: Clean up plugin publishing guide
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-docs/pull/548
Clean up plugin publishing guide
@riknoll can you please help review?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs publish
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-docs/pull/548.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #548
----
commit c8ec1e8f97df22e4e18a66f70c68b0140b0c6f34
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date: 2016-03-09T18:53:35Z
Update details for publishing plugins
commit 34d81de0cfe0ab898527b0a9854bf22fad34e36a
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date: 2016-03-09T19:13:03Z
Remove authors.html page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Clean up plugin publishing guide
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/548#issuecomment-196650847
Plugin publishing guide needed the same content as well - and most of the content was out-of-date.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Clean up plugin publishing guide
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/548#discussion_r55643472
--- Diff: www/docs/en/dev/guide/hybrid/plugins/index.md ---
@@ -224,7 +218,21 @@ To publish a plugin to NPM registry you need to follow steps below:
$ npm adduser # that is if you don't have an account yet
$ npm publish /path/to/your/plugin
-That is it!
+For more details on npm usage refer to [publishing a npm package](https://docs.npmjs.com/getting-started/publishing-npm-packages) on the NPM documentation site.
+
+## Integrating with Cordova Plugin Search
+To surface the plugin in [Cordova Plugin Search](/plugins/), add the `ecosystem:cordova` keyword to the `package.json` file of your plugin and publish it to npm registry.
--- End diff --
the "ecosystem:cordova" is added by plugman, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Clean up plugin publishing guide
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/548#issuecomment-195129017
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Clean up plugin publishing guide
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/548#issuecomment-195125079
@riknoll can you take a quick look as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Clean up plugin publishing guide
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/548#discussion_r56107342
--- Diff: www/static/plugins/app.js ---
@@ -458,7 +458,7 @@ var App = React.createClass({
</div>
<div className="plugins_links">
<ul className="nav nav-justified">
- <li><a href="{{ site.baseurl }}/plugins/authors.html"><span className="glyphicon glyphicon-plus"></span><i> </i>Contribute Plugins</a></li>
+ <li><a href="{{ site.baseurl }}/docs/en/latest/guide/hybrid/plugins/index.html#publishing-plugins"><span className="glyphicon glyphicon-plus"></span><i> </i>Contribute Plugins</a></li>
--- End diff --
Please use `{{ site.default_linked_docs_version }}` here instead of `/latest/`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Clean up plugin publishing guide
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/548#discussion_r55643636
--- Diff: www/docs/en/dev/guide/hybrid/plugins/index.md ---
@@ -224,7 +218,21 @@ To publish a plugin to NPM registry you need to follow steps below:
$ npm adduser # that is if you don't have an account yet
$ npm publish /path/to/your/plugin
-That is it!
+For more details on npm usage refer to [publishing a npm package](https://docs.npmjs.com/getting-started/publishing-npm-packages) on the NPM documentation site.
+
+## Integrating with Cordova Plugin Search
+To surface the plugin in [Cordova Plugin Search](/plugins/), add the `ecosystem:cordova` keyword to the `package.json` file of your plugin and publish it to npm registry.
+
+To indicate support for a particular platform add a keyword with the `<platformName>` as "**cordova-<platformName>**" to the list of keywords in package.json. For example, for a plugin that supports android, iOS & Windows, the keywords in package.json should include:
--- End diff --
This is added by plugman too. I think this should say that plugman add this important things. It seems that they have to add them manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Clean up plugin publishing guide
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/548#issuecomment-196619953
Why did we decide to stop having this as a page of its own?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-docs pull request: Clean up plugin publishing guide
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/548
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org