You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2016/02/12 01:18:24 UTC
[2/2] mesos git commit: Added documentation for labeled reserved
resources.
Added documentation for labeled reserved resources.
Review: https://reviews.apache.org/r/42755/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/3b02b80f
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/3b02b80f
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/3b02b80f
Branch: refs/heads/master
Commit: 3b02b80fae886caccd242f5fc205e91a42723861
Parents: 77448c0
Author: Neil Conway <ne...@gmail.com>
Authored: Thu Feb 11 16:07:05 2016 -0800
Committer: Michael Park <mp...@apache.org>
Committed: Thu Feb 11 16:07:05 2016 -0800
----------------------------------------------------------------------
docs/reservation.md | 27 ++++++++++++++++++++-------
1 file changed, 20 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/3b02b80f/docs/reservation.md
----------------------------------------------------------------------
diff --git a/docs/reservation.md b/docs/reservation.md
index 51fa7fc..d3ae445 100644
--- a/docs/reservation.md
+++ b/docs/reservation.md
@@ -65,13 +65,26 @@ see the [authorization documentation](authorization.md).
In the following sections, we will walk through examples of each of the
interfaces described above.
-Note that if two dynamic reservations are made for resources at a single slave,
-the reservations will be combined by adding together the resources reserved by
-each request. Similarly, "partial" unreserve operations are allowed: an
-unreserve operation can release only some of the resources at a slave that have
-been reserved for a given role. In this case, the unreserved resources will be
-subtracted from the previous reservation, and any remaining resources will still
-be reserved.
+If two dynamic reservations are made for the same role at a single slave (using
+the same labels, if any; see below), the reservations will be combined by adding
+together the resources reserved by each request. This will result in a single
+reserved resource at the slave. Similarly, "partial" unreserve operations are
+allowed: an unreserve operation can release some but not all of the resources at
+a slave that have been reserved for a role. In this case, the unreserved
+resources will be subtracted from the previous reservation and any remaining
+resources will still be reserved.
+
+
+### Labeled Reservations
+
+Dynamic reservations can optionally include a list of _labels_, which are
+arbitrary key-value pairs. Labels can be used to associate arbitrary metadata
+with a resource reservation. For example, frameworks can use labels to identify
+the intended purpose for a portion of the resources that have been reserved at a
+given slave. Note that two reservations with different labels will not be
+combined together into a single reservation, even if the reservations are at the
+same slave and use the same role.
+
### Framework Scheduler API
Re: [2/2] mesos git commit: Added documentation for labeled reserved resources.
Posted by Benjamin Mahler <bm...@apache.org>.
Got it, this is what I figured would be the answer :)
Just want to make sure this information is somewhat discoverable to the
user (e.g. a note on reservation info that references MESOS-4476).
On Sat, Feb 13, 2016 at 2:59 AM, Guangya Liu <gy...@gmail.com> wrote:
> Neil, I think what you want to show for setting reservationInfo for static
> reservation is https://issues.apache.org/jira/browse/MESOS-4476
>
> On Sat, Feb 13, 2016 at 2:16 AM, Neil Conway <ne...@gmail.com>
> wrote:
>
> > Hi Ben,
> >
> > On Fri, Feb 12, 2016 at 2:34 AM, Benjamin Mahler <bm...@apache.org>
> > wrote:
> > > Any plans to support labels for static reservations?
> > >
> > > Are we intentionally not supporting ReservationInfo for static
> > > reservations? Or is this just outside of the initial scope?
> >
> > Labels for static reservations are not currently supported because
> > `labels` is part of `ReservationInfo`, and the latter is not set for
> > static reservations.
> >
> > Setting ReservationInfo for static reservations is
> > https://issues.apache.org/jira/browse/MESOS-3486 . I didn't take this
> > on right now, because there are some backward compatibility concerns
> > with making this change. It is also unclear if we want to continue
> > adding features to static reservations vs. continuing to enhance
> > dynamic reservations to the point at which they can replace static
> > reservations for most use cases.
> >
> > Neil
> >
>
Re: [2/2] mesos git commit: Added documentation for labeled reserved resources.
Posted by Benjamin Mahler <bm...@apache.org>.
Got it, this is what I figured would be the answer :)
Just want to make sure this information is somewhat discoverable to the
user (e.g. a note on reservation info that references MESOS-4476).
On Sat, Feb 13, 2016 at 2:59 AM, Guangya Liu <gy...@gmail.com> wrote:
> Neil, I think what you want to show for setting reservationInfo for static
> reservation is https://issues.apache.org/jira/browse/MESOS-4476
>
> On Sat, Feb 13, 2016 at 2:16 AM, Neil Conway <ne...@gmail.com>
> wrote:
>
> > Hi Ben,
> >
> > On Fri, Feb 12, 2016 at 2:34 AM, Benjamin Mahler <bm...@apache.org>
> > wrote:
> > > Any plans to support labels for static reservations?
> > >
> > > Are we intentionally not supporting ReservationInfo for static
> > > reservations? Or is this just outside of the initial scope?
> >
> > Labels for static reservations are not currently supported because
> > `labels` is part of `ReservationInfo`, and the latter is not set for
> > static reservations.
> >
> > Setting ReservationInfo for static reservations is
> > https://issues.apache.org/jira/browse/MESOS-3486 . I didn't take this
> > on right now, because there are some backward compatibility concerns
> > with making this change. It is also unclear if we want to continue
> > adding features to static reservations vs. continuing to enhance
> > dynamic reservations to the point at which they can replace static
> > reservations for most use cases.
> >
> > Neil
> >
>
Re: [2/2] mesos git commit: Added documentation for labeled reserved resources.
Posted by Guangya Liu <gy...@gmail.com>.
Neil, I think what you want to show for setting reservationInfo for static
reservation is https://issues.apache.org/jira/browse/MESOS-4476
On Sat, Feb 13, 2016 at 2:16 AM, Neil Conway <ne...@gmail.com> wrote:
> Hi Ben,
>
> On Fri, Feb 12, 2016 at 2:34 AM, Benjamin Mahler <bm...@apache.org>
> wrote:
> > Any plans to support labels for static reservations?
> >
> > Are we intentionally not supporting ReservationInfo for static
> > reservations? Or is this just outside of the initial scope?
>
> Labels for static reservations are not currently supported because
> `labels` is part of `ReservationInfo`, and the latter is not set for
> static reservations.
>
> Setting ReservationInfo for static reservations is
> https://issues.apache.org/jira/browse/MESOS-3486 . I didn't take this
> on right now, because there are some backward compatibility concerns
> with making this change. It is also unclear if we want to continue
> adding features to static reservations vs. continuing to enhance
> dynamic reservations to the point at which they can replace static
> reservations for most use cases.
>
> Neil
>
Re: [2/2] mesos git commit: Added documentation for labeled reserved resources.
Posted by Neil Conway <ne...@gmail.com>.
Hi Ben,
On Fri, Feb 12, 2016 at 2:34 AM, Benjamin Mahler <bm...@apache.org> wrote:
> Any plans to support labels for static reservations?
>
> Are we intentionally not supporting ReservationInfo for static
> reservations? Or is this just outside of the initial scope?
Labels for static reservations are not currently supported because
`labels` is part of `ReservationInfo`, and the latter is not set for
static reservations.
Setting ReservationInfo for static reservations is
https://issues.apache.org/jira/browse/MESOS-3486 . I didn't take this
on right now, because there are some backward compatibility concerns
with making this change. It is also unclear if we want to continue
adding features to static reservations vs. continuing to enhance
dynamic reservations to the point at which they can replace static
reservations for most use cases.
Neil
Re: [2/2] mesos git commit: Added documentation for labeled reserved resources.
Posted by Benjamin Mahler <bm...@apache.org>.
Any plans to support labels for static reservations?
Are we intentionally not supporting ReservationInfo for static
reservations? Or is this just outside of the initial scope?
On Fri, Feb 12, 2016 at 1:18 AM, <mp...@apache.org> wrote:
> Added documentation for labeled reserved resources.
>
> Review: https://reviews.apache.org/r/42755/
>
>
> Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
> Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/3b02b80f
> Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/3b02b80f
> Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/3b02b80f
>
> Branch: refs/heads/master
> Commit: 3b02b80fae886caccd242f5fc205e91a42723861
> Parents: 77448c0
> Author: Neil Conway <ne...@gmail.com>
> Authored: Thu Feb 11 16:07:05 2016 -0800
> Committer: Michael Park <mp...@apache.org>
> Committed: Thu Feb 11 16:07:05 2016 -0800
>
> ----------------------------------------------------------------------
> docs/reservation.md | 27 ++++++++++++++++++++-------
> 1 file changed, 20 insertions(+), 7 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/mesos/blob/3b02b80f/docs/reservation.md
> ----------------------------------------------------------------------
> diff --git a/docs/reservation.md b/docs/reservation.md
> index 51fa7fc..d3ae445 100644
> --- a/docs/reservation.md
> +++ b/docs/reservation.md
> @@ -65,13 +65,26 @@ see the [authorization documentation](authorization.md
> ).
> In the following sections, we will walk through examples of each of the
> interfaces described above.
>
> -Note that if two dynamic reservations are made for resources at a single
> slave,
> -the reservations will be combined by adding together the resources
> reserved by
> -each request. Similarly, "partial" unreserve operations are allowed: an
> -unreserve operation can release only some of the resources at a slave
> that have
> -been reserved for a given role. In this case, the unreserved resources
> will be
> -subtracted from the previous reservation, and any remaining resources
> will still
> -be reserved.
> +If two dynamic reservations are made for the same role at a single slave
> (using
> +the same labels, if any; see below), the reservations will be combined by
> adding
> +together the resources reserved by each request. This will result in a
> single
> +reserved resource at the slave. Similarly, "partial" unreserve operations
> are
> +allowed: an unreserve operation can release some but not all of the
> resources at
> +a slave that have been reserved for a role. In this case, the unreserved
> +resources will be subtracted from the previous reservation and any
> remaining
> +resources will still be reserved.
> +
> +
> +### Labeled Reservations
> +
> +Dynamic reservations can optionally include a list of _labels_, which are
> +arbitrary key-value pairs. Labels can be used to associate arbitrary
> metadata
> +with a resource reservation. For example, frameworks can use labels to
> identify
> +the intended purpose for a portion of the resources that have been
> reserved at a
> +given slave. Note that two reservations with different labels will not be
> +combined together into a single reservation, even if the reservations are
> at the
> +same slave and use the same role.
> +
>
> ### Framework Scheduler API
>
>
>
Re: [2/2] mesos git commit: Added documentation for labeled reserved resources.
Posted by Benjamin Mahler <bm...@apache.org>.
Any plans to support labels for static reservations?
Are we intentionally not supporting ReservationInfo for static
reservations? Or is this just outside of the initial scope?
On Fri, Feb 12, 2016 at 1:18 AM, <mp...@apache.org> wrote:
> Added documentation for labeled reserved resources.
>
> Review: https://reviews.apache.org/r/42755/
>
>
> Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
> Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/3b02b80f
> Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/3b02b80f
> Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/3b02b80f
>
> Branch: refs/heads/master
> Commit: 3b02b80fae886caccd242f5fc205e91a42723861
> Parents: 77448c0
> Author: Neil Conway <ne...@gmail.com>
> Authored: Thu Feb 11 16:07:05 2016 -0800
> Committer: Michael Park <mp...@apache.org>
> Committed: Thu Feb 11 16:07:05 2016 -0800
>
> ----------------------------------------------------------------------
> docs/reservation.md | 27 ++++++++++++++++++++-------
> 1 file changed, 20 insertions(+), 7 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/mesos/blob/3b02b80f/docs/reservation.md
> ----------------------------------------------------------------------
> diff --git a/docs/reservation.md b/docs/reservation.md
> index 51fa7fc..d3ae445 100644
> --- a/docs/reservation.md
> +++ b/docs/reservation.md
> @@ -65,13 +65,26 @@ see the [authorization documentation](authorization.md
> ).
> In the following sections, we will walk through examples of each of the
> interfaces described above.
>
> -Note that if two dynamic reservations are made for resources at a single
> slave,
> -the reservations will be combined by adding together the resources
> reserved by
> -each request. Similarly, "partial" unreserve operations are allowed: an
> -unreserve operation can release only some of the resources at a slave
> that have
> -been reserved for a given role. In this case, the unreserved resources
> will be
> -subtracted from the previous reservation, and any remaining resources
> will still
> -be reserved.
> +If two dynamic reservations are made for the same role at a single slave
> (using
> +the same labels, if any; see below), the reservations will be combined by
> adding
> +together the resources reserved by each request. This will result in a
> single
> +reserved resource at the slave. Similarly, "partial" unreserve operations
> are
> +allowed: an unreserve operation can release some but not all of the
> resources at
> +a slave that have been reserved for a role. In this case, the unreserved
> +resources will be subtracted from the previous reservation and any
> remaining
> +resources will still be reserved.
> +
> +
> +### Labeled Reservations
> +
> +Dynamic reservations can optionally include a list of _labels_, which are
> +arbitrary key-value pairs. Labels can be used to associate arbitrary
> metadata
> +with a resource reservation. For example, frameworks can use labels to
> identify
> +the intended purpose for a portion of the resources that have been
> reserved at a
> +given slave. Note that two reservations with different labels will not be
> +combined together into a single reservation, even if the reservations are
> at the
> +same slave and use the same role.
> +
>
> ### Framework Scheduler API
>
>
>