You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Howard Lewis Ship <hl...@gmail.com> on 2006/04/08 22:58:42 UTC

Some issues with 4.0.1

Been looking at 4.0.1 (really, SVN head).

I'm finding a couple of places where the code uses direct references
to Log4J API, rather than commons-logging.  I'm changing those back to
commons-logging.

I'm also seeing some build failures:

Testcase: testRewinding(org.apache.tapestry.html.TestShell):        FAILED

  Unexpected method call getResponseBuilder():
    getResponseBuilder(): expected: 0, actual: 1
junit.framework.AssertionFailedError:
  Unexpected method call getResponseBuilder():
    getResponseBuilder(): expected: 0, actual: 1
    at org.easymock.internal.ObjectMethodsFilter.invoke(ObjectMethodsFilter.java:44)
    at $Proxy0.getResponseBuilder(Unknown Source)
    at org.apache.tapestry.AbstractComponent.renderBody(AbstractComponent.java:434)
    at org.apache.tapestry.html.Shell.renderComponent(Shell.java:119)
    at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java:617)
    at org.apache.tapestry.html.TestShell.testRewinding(TestShell.java:75)


--
Howard M. Lewis Ship
Independent J2EE / Open-Source Java Consultant
Creator, Jakarta Tapestry
Creator, Jakarta HiveMind

Professional Tapestry training, mentoring, support
and project work.  http://howardlewisship.com

---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


Re: Some issues with 4.0.1

Posted by Howard Lewis Ship <hl...@gmail.com>.
At this point, stay working in the trunk. Activity is pretty low right
now, but we'll all want to get in the habit of creating branches and
then merging back in. It's very straightforward (as long as files
aren't renamed or moved).  For my client work, we all work in branches
and merge constantly ... don't be stingy about creating branches,
they're cheap!

On 4/8/06, Jesse Kuhnert <jk...@gmail.com> wrote:
> Sorry about the logging imports. I must have done that at some point.
>
> The failed unit tests are because of some of the recent work involving the
> render cycle. Ideally I wanted to not check these things in until they were
> somewhat more stable, but because I tend to be nomadic somewhat with
> computer locations I went ahead and committed them.
>
> Should I be doing this in a branch, or just leave things local until I
> really have basic tests not failing anymore ?
>
> On 4/8/06, Howard Lewis Ship <hl...@gmail.com> wrote:
> >
> > Been looking at 4.0.1 (really, SVN head).
> >
> > I'm finding a couple of places where the code uses direct references
> > to Log4J API, rather than commons-logging.  I'm changing those back to
> > commons-logging.
> >
> > I'm also seeing some build failures:
> >
> > Testcase: testRewinding(org.apache.tapestry.html.TestShell):        FAILED
> >
> >   Unexpected method call getResponseBuilder():
> >     getResponseBuilder(): expected: 0, actual: 1
> > junit.framework.AssertionFailedError:
> >   Unexpected method call getResponseBuilder():
> >     getResponseBuilder(): expected: 0, actual: 1
> >     at org.easymock.internal.ObjectMethodsFilter.invoke(
> > ObjectMethodsFilter.java:44)
> >     at $Proxy0.getResponseBuilder(Unknown Source)
> >     at org.apache.tapestry.AbstractComponent.renderBody(
> > AbstractComponent.java:434)
> >     at org.apache.tapestry.html.Shell.renderComponent(Shell.java:119)
> >     at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java
> > :617)
> >     at org.apache.tapestry.html.TestShell.testRewinding(TestShell.java:75)
> >
> >
> > --
> > Howard M. Lewis Ship
> > Independent J2EE / Open-Source Java Consultant
> > Creator, Jakarta Tapestry
> > Creator, Jakarta HiveMind
> >
> > Professional Tapestry training, mentoring, support
> > and project work.  http://howardlewisship.com
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
> >
> >
>
>
> --
> Jesse Kuhnert
> Tacos/Tapestry, team member/developer
>
> Open source based consulting work centered around
> dojo/tapestry/tacos/hivemind.  http://opennotion.com
>
>


--
Howard M. Lewis Ship
Independent J2EE / Open-Source Java Consultant
Creator, Jakarta Tapestry
Creator, Jakarta HiveMind

Professional Tapestry training, mentoring, support
and project work.  http://howardlewisship.com

---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org


Re: Some issues with 4.0.1

Posted by Jesse Kuhnert <jk...@gmail.com>.
Sorry about the logging imports. I must have done that at some point.

The failed unit tests are because of some of the recent work involving the
render cycle. Ideally I wanted to not check these things in until they were
somewhat more stable, but because I tend to be nomadic somewhat with
computer locations I went ahead and committed them.

Should I be doing this in a branch, or just leave things local until I
really have basic tests not failing anymore ?

On 4/8/06, Howard Lewis Ship <hl...@gmail.com> wrote:
>
> Been looking at 4.0.1 (really, SVN head).
>
> I'm finding a couple of places where the code uses direct references
> to Log4J API, rather than commons-logging.  I'm changing those back to
> commons-logging.
>
> I'm also seeing some build failures:
>
> Testcase: testRewinding(org.apache.tapestry.html.TestShell):        FAILED
>
>   Unexpected method call getResponseBuilder():
>     getResponseBuilder(): expected: 0, actual: 1
> junit.framework.AssertionFailedError:
>   Unexpected method call getResponseBuilder():
>     getResponseBuilder(): expected: 0, actual: 1
>     at org.easymock.internal.ObjectMethodsFilter.invoke(
> ObjectMethodsFilter.java:44)
>     at $Proxy0.getResponseBuilder(Unknown Source)
>     at org.apache.tapestry.AbstractComponent.renderBody(
> AbstractComponent.java:434)
>     at org.apache.tapestry.html.Shell.renderComponent(Shell.java:119)
>     at org.apache.tapestry.AbstractComponent.render(AbstractComponent.java
> :617)
>     at org.apache.tapestry.html.TestShell.testRewinding(TestShell.java:75)
>
>
> --
> Howard M. Lewis Ship
> Independent J2EE / Open-Source Java Consultant
> Creator, Jakarta Tapestry
> Creator, Jakarta HiveMind
>
> Professional Tapestry training, mentoring, support
> and project work.  http://howardlewisship.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
>
>


--
Jesse Kuhnert
Tacos/Tapestry, team member/developer

Open source based consulting work centered around
dojo/tapestry/tacos/hivemind.  http://opennotion.com