You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/22 12:57:39 UTC
[GitHub] [flink] XComp opened a new pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
XComp opened a new pull request #13747:
URL: https://github.com/apache/flink/pull/13747
## What is the purpose of the change
We want to expose the JobManager's effective configuration through the `/jobmanager/config` REST endpoint. That way, we can expose these values in the web UI as it is suggested in [FLIP-104](https://cwiki.apache.org/confluence/display/FLINK/FLIP-104%3A+Add+More+Metrics+to+Jobmanager).
## Brief change log
- Added method to generate dynamic parameters from configuration
- Added dynamic parameters to BashJavaUtils' JobManager argument extraction and integrated the new functionality in multiple script starting the JobManager directly or indirectly.
## Verifying this change
- Added test to JobManagerProcessUtilsTest to check whether the dynamic parameter list generation works correctly.
- Extended BashJavaUtilsITCase to check whether the dynamic properties are returned by BashJavaUtilsITCase.
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? not documented (the specific configuration parameters exposed through the REST endpoint are not documented in general)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 291650ee0b8802a168b227cd4749f58d14a256a3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #13747:
URL: https://github.com/apache/flink/pull/13747#discussion_r512551949
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -72,20 +79,23 @@ public void testGetTmResourceParamsConfigsWithDynamicProperties() throws Excepti
@Test
public void testGetJmResourceParams() throws Exception {
- int expectedResultLines = 1;
+ int expectedResultLines = 2;
Review comment:
Yup, I planned to squash all the commits in a proper way after the review is done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #13747:
URL: https://github.com/apache/flink/pull/13747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1367b5d47211daa100e12c351182051a1b5e00cd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
}, {
"hash" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429",
"triggerID" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* 471a7bf60d06f37310511f069f19d1ea762ef698 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425)
* b5d2cee9556de0d3120a0b430ac5d1e55fd157ff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #13747:
URL: https://github.com/apache/flink/pull/13747#discussion_r512551392
##########
File path: flink-dist/src/main/flink-bin/bin/jobmanager.sh
##########
@@ -51,6 +51,10 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP == "start-foreground" ]]; then
args+=("--webui-port")
args+=("${WEBUIPORT}")
fi
+
+ if [ ! -z "${DYNAMIC_PARAMETERS+x}" ]; then
Review comment:
True I forgot to align all of that. The variable extension is not necessary in our case. Hence, I removed it again aligning all three code snippets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
}, {
"hash" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429",
"triggerID" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"triggerType" : "PUSH"
}, {
"hash" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8612",
"triggerID" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* fc84ca88517652982a1f136a57a7b13311e1cc0c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8612)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
}, {
"hash" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429",
"triggerID" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* b5d2cee9556de0d3120a0b430ac5d1e55fd157ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1dc2d0a4b8283574e961ae64b4e206a32cf6e2be Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114)
* 1367b5d47211daa100e12c351182051a1b5e00cd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
}, {
"hash" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429",
"triggerID" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"triggerType" : "PUSH"
}, {
"hash" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8612",
"triggerID" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f722c99b83591793147b2dda952a3acadf5f2b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8821",
"triggerID" : "7f722c99b83591793147b2dda952a3acadf5f2b7",
"triggerType" : "PUSH"
}, {
"hash" : "1ca98b02a8fffeb019697c7cfa8c59f775d793fd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8899",
"triggerID" : "1ca98b02a8fffeb019697c7cfa8c59f775d793fd",
"triggerType" : "PUSH"
}, {
"hash" : "3dbcbac34b060ae4b481277574505d74fdc2a34c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8989",
"triggerID" : "3dbcbac34b060ae4b481277574505d74fdc2a34c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* 3dbcbac34b060ae4b481277574505d74fdc2a34c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8989)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-718811927
@tillrohrmann I tested whether the memory configuration pops up when accessing `job-managers/config` manually for:
* local standalone cluster (using `./bin/jobmanager.sh` through `./bin/start-cluster.sh`)
* Kubernetes Session Cluster (using `./bin/kubernetes-session.sh # ...`)
* Kubernetes Job Cluster (using `./bin/flink run-application -p 8 -t kubernetes-application # ...`)
* Yarn Session Cluster (using `./bin/yarn-session.sh -jm 1024m -tm 4096`)
* Yarn Job Cluster (using `./bin/flink run -m yarn-cluster -p 4 # ...`)
Additionally, I verified the parameters passing for `./bin/mesos-appmaster.sh` and `./bin/mesos-appmaster-job.sh` which both execute `./bin/mesos-jobmanager.sh`. I also did a code review of passing the configuration trough `MesosJobClusterEntrypoint` and `MesosSessionClusterEntrypoint` to `LaunchableMesosWorker`.
All looks good. So, I guess, the code is ready to get another review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
}, {
"hash" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429",
"triggerID" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"triggerType" : "PUSH"
}, {
"hash" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8612",
"triggerID" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* b5d2cee9556de0d3120a0b430ac5d1e55fd157ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429)
* fc84ca88517652982a1f136a57a7b13311e1cc0c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8612)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #13747:
URL: https://github.com/apache/flink/pull/13747#discussion_r512553693
##########
File path: flink-dist/src/main/flink-bin/bin/jobmanager.sh
##########
@@ -51,6 +51,10 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP == "start-foreground" ]]; then
args+=("--webui-port")
args+=("${WEBUIPORT}")
fi
+
+ if [ ! -z "${DYNAMIC_PARAMETERS+x}" ]; then
+ for v in ${DYNAMIC_PARAMETERS[@]}; do args+=($v); done
Review comment:
When I implemented it firstly, I ran into issues. Hence, I used the for loop option. I addressed it again and it worked. No clue, what was wrong in the first place. 🤔 Anyway, I fixed it. Now, the `args` array simply gets concatenated with the `DYNAMIC_PARAMETERS` array.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714475833
@tillrohrmann Feel free to have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
}, {
"hash" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429",
"triggerID" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"triggerType" : "PUSH"
}, {
"hash" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* b5d2cee9556de0d3120a0b430ac5d1e55fd157ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429)
* fc84ca88517652982a1f136a57a7b13311e1cc0c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 291650ee0b8802a168b227cd4749f58d14a256a3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181)
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* 98b10aceb3134042aaa68784edaf631657ce1c52 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* 98b10aceb3134042aaa68784edaf631657ce1c52 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290)
* d5707a34a25a69e25cd78104a9d6f6725dcd9d77 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #13747:
URL: https://github.com/apache/flink/pull/13747#discussion_r510950775
##########
File path: flink-dist/src/main/flink-bin/bin/jobmanager.sh
##########
@@ -51,6 +51,10 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP == "start-foreground" ]]; then
args+=("--webui-port")
args+=("${WEBUIPORT}")
fi
+
+ if [ ! -z "${DYNAMIC_PARAMETERS+x}" ]; then
Review comment:
Why is a `+x` appended to `DYNAMIC_PARAMETERS`? In the other scripts this suffix is missing.
##########
File path: flink-dist/src/main/flink-bin/bin/jobmanager.sh
##########
@@ -51,6 +51,10 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP == "start-foreground" ]]; then
args+=("--webui-port")
args+=("${WEBUIPORT}")
fi
+
+ if [ ! -z "${DYNAMIC_PARAMETERS+x}" ]; then
+ for v in ${DYNAMIC_PARAMETERS[@]}; do args+=($v); done
Review comment:
Why do we have to add it in a loop to `args`? Is this some bash magic?
##########
File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
##########
@@ -72,20 +79,23 @@ public void testGetTmResourceParamsConfigsWithDynamicProperties() throws Excepti
@Test
public void testGetJmResourceParams() throws Exception {
- int expectedResultLines = 1;
+ int expectedResultLines = 2;
Review comment:
I guess that this commit should be merged together with the previous one because w/o, the previous commit should fail in this test here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 291650ee0b8802a168b227cd4749f58d14a256a3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181)
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-717125736
@tillrohrmann I addressed your issues and waited for the Azure pipeline to succeed. I continued with reorganizing the commits. Feel free to have another look. In the meantime, I'm still trying to test the changes manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
}, {
"hash" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429",
"triggerID" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"triggerType" : "PUSH"
}, {
"hash" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8612",
"triggerID" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f722c99b83591793147b2dda952a3acadf5f2b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8821",
"triggerID" : "7f722c99b83591793147b2dda952a3acadf5f2b7",
"triggerType" : "PUSH"
}, {
"hash" : "1ca98b02a8fffeb019697c7cfa8c59f775d793fd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8899",
"triggerID" : "1ca98b02a8fffeb019697c7cfa8c59f775d793fd",
"triggerType" : "PUSH"
}, {
"hash" : "3dbcbac34b060ae4b481277574505d74fdc2a34c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8989",
"triggerID" : "3dbcbac34b060ae4b481277574505d74fdc2a34c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* 1ca98b02a8fffeb019697c7cfa8c59f775d793fd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8899)
* 3dbcbac34b060ae4b481277574505d74fdc2a34c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8989)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
}, {
"hash" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429",
"triggerID" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"triggerType" : "PUSH"
}, {
"hash" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8612",
"triggerID" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f722c99b83591793147b2dda952a3acadf5f2b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8821",
"triggerID" : "7f722c99b83591793147b2dda952a3acadf5f2b7",
"triggerType" : "PUSH"
}, {
"hash" : "1ca98b02a8fffeb019697c7cfa8c59f775d793fd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8899",
"triggerID" : "1ca98b02a8fffeb019697c7cfa8c59f775d793fd",
"triggerType" : "PUSH"
}, {
"hash" : "3dbcbac34b060ae4b481277574505d74fdc2a34c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3dbcbac34b060ae4b481277574505d74fdc2a34c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* 1ca98b02a8fffeb019697c7cfa8c59f775d793fd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8899)
* 3dbcbac34b060ae4b481277574505d74fdc2a34c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1367b5d47211daa100e12c351182051a1b5e00cd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132)
* 291650ee0b8802a168b227cd4749f58d14a256a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1dc2d0a4b8283574e961ae64b4e206a32cf6e2be UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1367b5d47211daa100e12c351182051a1b5e00cd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132)
* 291650ee0b8802a168b227cd4749f58d14a256a3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* 98b10aceb3134042aaa68784edaf631657ce1c52 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290)
* d5707a34a25a69e25cd78104a9d6f6725dcd9d77 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
}, {
"hash" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* e1297729245bafba085114aaaf29e7a9c1bca027 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391)
* 471a7bf60d06f37310511f069f19d1ea762ef698 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425)
* b5d2cee9556de0d3120a0b430ac5d1e55fd157ff UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
}, {
"hash" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429",
"triggerID" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"triggerType" : "PUSH"
}, {
"hash" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8612",
"triggerID" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f722c99b83591793147b2dda952a3acadf5f2b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8821",
"triggerID" : "7f722c99b83591793147b2dda952a3acadf5f2b7",
"triggerType" : "PUSH"
}, {
"hash" : "1ca98b02a8fffeb019697c7cfa8c59f775d793fd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8899",
"triggerID" : "1ca98b02a8fffeb019697c7cfa8c59f775d793fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* 7f722c99b83591793147b2dda952a3acadf5f2b7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8821)
* 1ca98b02a8fffeb019697c7cfa8c59f775d793fd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8899)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
}, {
"hash" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429",
"triggerID" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"triggerType" : "PUSH"
}, {
"hash" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8612",
"triggerID" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f722c99b83591793147b2dda952a3acadf5f2b7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8821",
"triggerID" : "7f722c99b83591793147b2dda952a3acadf5f2b7",
"triggerType" : "PUSH"
}, {
"hash" : "1ca98b02a8fffeb019697c7cfa8c59f775d793fd",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8899",
"triggerID" : "1ca98b02a8fffeb019697c7cfa8c59f775d793fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* 1ca98b02a8fffeb019697c7cfa8c59f775d793fd Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8899)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* e1297729245bafba085114aaaf29e7a9c1bca027 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #13747:
URL: https://github.com/apache/flink/pull/13747#discussion_r516107826
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtils.java
##########
@@ -51,8 +56,24 @@
*/
public class YarnEntrypointUtils {
- public static Configuration loadConfiguration(String workingDirectory, Map<String, String> env) {
- Configuration configuration = GlobalConfiguration.loadConfiguration(workingDirectory);
+ private static final Logger LOG = LoggerFactory.getLogger(YarnEntrypointUtils.class);
+
+ public static Configuration loadConfiguration(String workingDirectory, String[] args, Map<String, String> env) {
+ Configuration dynamicParameters = null;
+ final CommandLineParser<Configuration> commandLineParser = new CommandLineParser<>(
+ new DynamicParametersConfigurationParserFactory());
+
+ try {
+ dynamicParameters = commandLineParser.parse(args);
+ } catch (FlinkParseException e) {
+ LOG.error("Could not parse command line arguments {}.", args, e);
+ commandLineParser.printHelp(StandaloneSessionClusterEntrypoint.class.getSimpleName());
+ System.exit(1);
+ }
Review comment:
You have a good point. I looked into the code again and realized that it's not ideal (the current version and your proposal moving everything in a single utility method). I don't consider calling `System.exit(..)` within a utility method good coding. Such a call should be located in the main method.
Moving the left-over code into a utility method would have meant splitting up the error handling (since `CommandLineParser.printHelp(..)` would have still been called within the utility method).
I didn't consider splitting up the error handling being a good approach either. Hence, I moved the dynamic parameter parsing into each main method in [7f722c9](https://github.com/apache/flink/pull/13747/commits/7f722c99b83591793147b2dda952a3acadf5f2b7). What's your take on this?
FYI: The commit above also fixed a bug that used the wrong class in `CommandLineParser.printHelp(..)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1dc2d0a4b8283574e961ae64b4e206a32cf6e2be Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114)
* 1367b5d47211daa100e12c351182051a1b5e00cd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1dc2d0a4b8283574e961ae64b4e206a32cf6e2be Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* e1297729245bafba085114aaaf29e7a9c1bca027 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391)
* 471a7bf60d06f37310511f069f19d1ea762ef698 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #13747:
URL: https://github.com/apache/flink/pull/13747#discussion_r516025408
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/DynamicParametersConfigurationParserFactory.java
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.entrypoint;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.ConfigurationUtils;
+import org.apache.flink.runtime.entrypoint.parser.ParserResultFactory;
+
+import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.Options;
+
+import javax.annotation.Nonnull;
+
+import java.util.Properties;
+
+import static org.apache.flink.runtime.entrypoint.parser.CommandLineOptions.DYNAMIC_PROPERTY_OPTION;
+
+/**
+ * {@code DynamicParametersCOnfigurationParserFactory} can be used to extract the dynamic parameters
Review comment:
typo: COnfiguration
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnEntrypointUtils.java
##########
@@ -51,8 +56,24 @@
*/
public class YarnEntrypointUtils {
- public static Configuration loadConfiguration(String workingDirectory, Map<String, String> env) {
- Configuration configuration = GlobalConfiguration.loadConfiguration(workingDirectory);
+ private static final Logger LOG = LoggerFactory.getLogger(YarnEntrypointUtils.class);
+
+ public static Configuration loadConfiguration(String workingDirectory, String[] args, Map<String, String> env) {
+ Configuration dynamicParameters = null;
+ final CommandLineParser<Configuration> commandLineParser = new CommandLineParser<>(
+ new DynamicParametersConfigurationParserFactory());
+
+ try {
+ dynamicParameters = commandLineParser.parse(args);
+ } catch (FlinkParseException e) {
+ LOG.error("Could not parse command line arguments {}.", args, e);
+ commandLineParser.printHelp(StandaloneSessionClusterEntrypoint.class.getSimpleName());
+ System.exit(1);
+ }
Review comment:
This snipped looks quite similar to what you've put into the `KubernetesEntrypointUtils`. I'd suggest to factor it out and to reuse it. Maybe even pass `dynamicParameters` into this method instead of `args`.
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnSessionClusterEntrypoint.java
##########
@@ -73,7 +76,17 @@ public static void main(String[] args) {
LOG.warn("Could not log YARN environment information.", e);
}
- Configuration configuration = YarnEntrypointUtils.loadConfiguration(workingDirectory, env);
+ final CommandLineParser<Configuration> commandLineParser = new CommandLineParser<>(new DynamicParametersConfigurationParserFactory());
+ Configuration dynamicParameters = null;
+ try {
+ dynamicParameters = commandLineParser.parse(args);
+ } catch (FlinkParseException e) {
+ LOG.error("Could not parse command line arguments {}.", args, e);
+ commandLineParser.printHelp(YarnSessionClusterEntrypoint.class.getSimpleName());
+ System.exit(1);
+ }
Review comment:
Maybe one could introduce
```
private static <T> T parseArgumentsOrExit(
Logger logger,
String componentName,
String[] args,
ParserResultFactory<T> parserResultFactory) {
final CommandLineParser<T> commandLineParser = new CommandLineParser<>(parserResultFactory);
try {
return commandLineParser.parse(args);
} catch (FlinkParseException e) {
logger.error("Could not parse command line arguments {}.", args, e);
commandLineParser.printHelp(componentName);
System.exit(1);
return null;
}
}
```
into `ClusterEntrypointUtils` and use it across the cluster entrypoints. This would also ensure that we fail with a consistent error code if the parsing fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* d5707a34a25a69e25cd78104a9d6f6725dcd9d77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-715257079
I created [FLINK-19788](https://issues.apache.org/jira/browse/FLINK-19788) as ShuffleCompressionITCase.testDataCompressionForBlockingShuffle [failed](https://dev.azure.com/mapohl/flink/_build/results?buildId=92&view=logs&j=70ad9b63-500e-5dc9-5a3c-b60356162d7e&t=944c7023-8984-5aa2-b5f8-54922bd90d3a) even though it seems to be unrelated to my changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
}, {
"hash" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8425",
"triggerID" : "471a7bf60d06f37310511f069f19d1ea762ef698",
"triggerType" : "PUSH"
}, {
"hash" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8429",
"triggerID" : "b5d2cee9556de0d3120a0b430ac5d1e55fd157ff",
"triggerType" : "PUSH"
}, {
"hash" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8612",
"triggerID" : "fc84ca88517652982a1f136a57a7b13311e1cc0c",
"triggerType" : "PUSH"
}, {
"hash" : "7f722c99b83591793147b2dda952a3acadf5f2b7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8821",
"triggerID" : "7f722c99b83591793147b2dda952a3acadf5f2b7",
"triggerType" : "PUSH"
}, {
"hash" : "1ca98b02a8fffeb019697c7cfa8c59f775d793fd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ca98b02a8fffeb019697c7cfa8c59f775d793fd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* 7f722c99b83591793147b2dda952a3acadf5f2b7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8821)
* 1ca98b02a8fffeb019697c7cfa8c59f775d793fd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #13747:
URL: https://github.com/apache/flink/pull/13747#discussion_r516691971
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnSessionClusterEntrypoint.java
##########
@@ -73,7 +76,17 @@ public static void main(String[] args) {
LOG.warn("Could not log YARN environment information.", e);
}
- Configuration configuration = YarnEntrypointUtils.loadConfiguration(workingDirectory, env);
+ final CommandLineParser<Configuration> commandLineParser = new CommandLineParser<>(new DynamicParametersConfigurationParserFactory());
+ Configuration dynamicParameters = null;
+ try {
+ dynamicParameters = commandLineParser.parse(args);
+ } catch (FlinkParseException e) {
+ LOG.error("Could not parse command line arguments {}.", args, e);
+ commandLineParser.printHelp(YarnSessionClusterEntrypoint.class.getSimpleName());
+ System.exit(1);
+ }
Review comment:
Ok, fair enough. I addressed the comments and pushed the changes. FYI: I also moved `ClusterEntrypointUtils` into the package of `ClusterEntrypoint` (i.e. `org.apache.flink.runtime.entrypoint`) since I wanted to use `ClusterEntrypoint.STARTUP_FAILURE_RETURN_CODE` in the newly introduced utility method.
Alternatively, I could have made `ClusterEntrypoint.STARTUP_FAILURE_RETURN_CODE` public. But moving `ClusterEntrypointUtils` felt like the right thing to do considering that other utility classes (e.g. `ClusterEntrypointExceptionUtils`) are also located in `org.apache.flink.runtime.entrypoint`. Any objections against that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* d5707a34a25a69e25cd78104a9d6f6725dcd9d77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318)
* e1297729245bafba085114aaaf29e7a9c1bca027 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8391)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8290",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
}, {
"hash" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318",
"triggerID" : "d5707a34a25a69e25cd78104a9d6f6725dcd9d77",
"triggerType" : "PUSH"
}, {
"hash" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e1297729245bafba085114aaaf29e7a9c1bca027",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* d5707a34a25a69e25cd78104a9d6f6725dcd9d77 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8318)
* e1297729245bafba085114aaaf29e7a9c1bca027 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1dc2d0a4b8283574e961ae64b4e206a32cf6e2be Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714516971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8114",
"triggerID" : "1dc2d0a4b8283574e961ae64b4e206a32cf6e2be",
"triggerType" : "PUSH"
}, {
"hash" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8132",
"triggerID" : "1367b5d47211daa100e12c351182051a1b5e00cd",
"triggerType" : "PUSH"
}, {
"hash" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181",
"triggerID" : "291650ee0b8802a168b227cd4749f58d14a256a3",
"triggerType" : "PUSH"
}, {
"hash" : "16c62023348b09568668f4e7135b665e5112b968",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "16c62023348b09568668f4e7135b665e5112b968",
"triggerType" : "PUSH"
}, {
"hash" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "98b10aceb3134042aaa68784edaf631657ce1c52",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 291650ee0b8802a168b227cd4749f58d14a256a3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8181)
* 16c62023348b09568668f4e7135b665e5112b968 UNKNOWN
* 98b10aceb3134042aaa68784edaf631657ce1c52 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13747: [FLINK-19662][runtime] Exposing the JobManager's memory configuration through /jobmanager/config
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13747:
URL: https://github.com/apache/flink/pull/13747#issuecomment-714476629
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1dc2d0a4b8283574e961ae64b4e206a32cf6e2be (Thu Oct 22 12:59:30 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org