[GitHub] lucene-solr pull request #451: LUCENE-8496: Add selective indexing to BKD/PO...

[iverase <gi...@git.apache.org>]

Github user iverase commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/451#discussion_r221581265
  
    --- Diff: lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD.java ---
    @@ -1063,7 +1064,7 @@ public void testWastedLeadingBytes() throws Exception {
     
         Directory dir = newFSDirectory(createTempDir());
         int numDocs = 100000;
    -    BKDWriter w = new BKDWriter(numDocs+1, dir, "tmp", numDims, bytesPerDim, 32, 1f, numDocs, true);
    +    BKDWriter w = new BKDWriter(numDocs+1, dir, "tmp", numDims, numDims, bytesPerDim, 32, 1f, numDocs, true);
    --- End diff --
    
    I have realised that the above assertion is incorrect for multivalued docs so please discard it. Maybe we can just assert the number of bytes in packedValue. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org