You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/12/15 23:23:54 UTC

[kudu-CR] [raft consensus] 3-4-3 replica management by default (1/3) 

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8856


Change subject: [raft_consensus] 3-4-3 replica management by default (1/3)
......................................................................

[raft_consensus] 3-4-3 replica management by default (1/3)

Updated all scenarios of the RaftConsensusNonVoterITest and
RaftConsensusITest to run with 3-4-3 replica management scheme

Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
4 files changed, 184 insertions(+), 54 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/8856/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [tests] update for 3-4-3 replica management scheme (1/3)

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8856

to look at the new patch set (#3).

Change subject: [tests] update for 3-4-3 replica management scheme (1/3)
......................................................................

[tests] update for 3-4-3 replica management scheme (1/3)

Updated all scenarios of the RaftConsensusNonVoterITest and
RaftConsensusITest to run with 3-4-3 replica management scheme.

Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
4 files changed, 184 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/8856/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [tests] update for 3-4-3 replica management scheme (1/3)

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8856 )

Change subject: [tests] update for 3-4-3 replica management scheme (1/3)
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8856/3/src/kudu/integration-tests/raft_consensus-itest.cc
File src/kudu/integration-tests/raft_consensus-itest.cc:

http://gerrit.cloudera.org:8080/#/c/8856/3/src/kudu/integration-tests/raft_consensus-itest.cc@2260
PS3, Line 2260: fall behind the leader's log GC threshold
> We need a test that a replica that falls into this state is replaced, even 
We already have a test which covers that as a part of its 3-4-3 scheme scenario: RaftConsensusNonVoterITest.FailedTabletCopy

I found updating this test to fit both 3-4-3 and 3-2-3 schemes to be a bit messy: there are too many if/else.

If you don't mind, I would like to keep this test just for 3-2-3 and rely on RaftConsensusNonVoterITest.FailedTabletCopy for corresponding coverage.



-- 
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 20 Dec 2017 02:45:55 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tests] update for 3-4-3 replica management scheme (1/3)

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8856 )

Change subject: [tests] update for 3-4-3 replica management scheme (1/3)
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8856/3/src/kudu/integration-tests/raft_consensus-itest.cc
File src/kudu/integration-tests/raft_consensus-itest.cc:

http://gerrit.cloudera.org:8080/#/c/8856/3/src/kudu/integration-tests/raft_consensus-itest.cc@2260
PS3, Line 2260: 
> We already have a test which covers that as a part of its 3-4-3 scheme scen
Oh, great. Thanks!



-- 
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 22 Dec 2017 21:36:53 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tests] update for 3-4-3 replica management scheme (1/3)

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8856

to look at the new patch set (#5).

Change subject: [tests] update for 3-4-3 replica management scheme (1/3)
......................................................................

[tests] update for 3-4-3 replica management scheme (1/3)

Updated all scenarios of the RaftConsensusNonVoterITest and
RaftConsensusITest to run with 3-4-3 replica management scheme.

This patch is a part of the work done in the context of KUDU-1097.

Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
4 files changed, 191 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/8856/5
-- 
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] [tests] update for 3-4-3 replica management scheme (1/3)

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8856 )

Change subject: [tests] update for 3-4-3 replica management scheme (1/3)
......................................................................

[tests] update for 3-4-3 replica management scheme (1/3)

Updated all scenarios of the RaftConsensusNonVoterITest and
RaftConsensusITest to run with 3-4-3 replica management scheme.

This patch is a part of the work done in the context of KUDU-1097.

Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Reviewed-on: http://gerrit.cloudera.org:8080/8856
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
4 files changed, 191 insertions(+), 54 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Mike Percy: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] [tests] update for 3-4-3 replica management scheme (1/3)

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/8856 )

Change subject: [tests] update for 3-4-3 replica management scheme (1/3)
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] [tests] update for 3-4-3 replica management scheme (1/3)

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8856

to look at the new patch set (#4).

Change subject: [tests] update for 3-4-3 replica management scheme (1/3)
......................................................................

[tests] update for 3-4-3 replica management scheme (1/3)

Updated all scenarios of the RaftConsensusNonVoterITest and
RaftConsensusITest to run with 3-4-3 replica management scheme.

This patch is a part of the work done in the context of KUDU-1097.

Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
4 files changed, 184 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/8856/4
-- 
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] [tests] update for 3-4-3 replica management scheme (1/3)

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8856 )

Change subject: [tests] update for 3-4-3 replica management scheme (1/3)
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sun, 24 Dec 2017 17:57:40 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] update for 3-4-3 replica management scheme (1/3)

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8856 )

Change subject: [tests] update for 3-4-3 replica management scheme (1/3)
......................................................................


Patch Set 4: Verified+1

Unrelated issue with dist_test:

 INFO 57984 run_isolated(173): Running ['/usr/bin/python', u'../../build-support/run_dist_test.py', u'-e', u'GTEST_SHARD_INDEX=0', u'-e', u'GTEST_TOTAL_SHARDS=1', u'-e', u'KUDU_TEST_TIMEOUT=870', u'-e', u'KUDU_ALLOW_SLOW_TESTS=1', u'-e', u'KUDU_COMPRESS_TEST_OUTPUT=1', u'--', u'../release/bin/table_locations-itest'], cwd=/tmp/run_tha_testDDpqKO/build/isolate Traceback (most recent call last): File "../../build-support/run_dist_test.py", line 157, in <module> main() File "../../build-support/run_dist_test.py", line 124, in main fixup_rpaths(os.path.join(ROOT, "thirdparty")) File "../../build-support/run_dist_test.py", line 91, in fixup_rpaths fix_rpath(p) File "../../build-support/run_dist_test.py", line 76, in fix_rpath rpath = re.search("R(?:UN)?PATH=(.+)", stdout.strip()).group(1) AttributeError: 'NoneType' object has no attribute 'group'


-- 
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 20 Dec 2017 22:41:24 +0000
Gerrit-HasComments: No

[kudu-CR] [test] update for 3-4-3 replica management scheme (2/3)

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8856

to look at the new patch set (#2).

Change subject: [test] update for 3-4-3 replica management scheme (2/3)
......................................................................

[test] update for 3-4-3 replica management scheme (2/3)

Updated all scenarios of the RaftConsensusNonVoterITest and
RaftConsensusITest to run with 3-4-3 replica management scheme.

Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
---
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/raft_consensus_election-itest.cc
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
4 files changed, 184 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/8856/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [tests] update for 3-4-3 replica management scheme (1/3)

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8856 )

Change subject: [tests] update for 3-4-3 replica management scheme (1/3)
......................................................................


Patch Set 3:

(1 comment)

Overall looks good.

http://gerrit.cloudera.org:8080/#/c/8856/3/src/kudu/integration-tests/raft_consensus-itest.cc
File src/kudu/integration-tests/raft_consensus-itest.cc:

http://gerrit.cloudera.org:8080/#/c/8856/3/src/kudu/integration-tests/raft_consensus-itest.cc@2260
PS3, Line 2260: fall behind the leader's log GC threshold
We need a test that a replica that falls into this state is replaced, even in the 3-4-3 scheme. Maybe this test can be repurposed to test that a failed replica gets "healed" in either the 3-2-3 or 3-4-3 scheme, regardless of the mechanism?

If we disable this test for 3-2-3, for coverage we will need to write a new test for 3-4-3. Maybe that is easier.



-- 
To view, visit http://gerrit.cloudera.org:8080/8856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6775a7c56dd1aeb028b556cc7abe11b7545c7d09
Gerrit-Change-Number: 8856
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 18 Dec 2017 20:02:20 +0000
Gerrit-HasComments: Yes