You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Arvind Prabhakar (Created) (JIRA)" <ji...@apache.org> on 2012/04/06 18:13:23 UTC

[jira] [Created] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Configuration keys for JDBC channel contain redundant prefix.
-------------------------------------------------------------

                 Key: FLUME-1107
                 URL: https://issues.apache.org/jira/browse/FLUME-1107
             Project: Flume
          Issue Type: Sub-task
            Reporter: Arvind Prabhakar
            Assignee: Arvind Prabhakar


The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 

For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
{code}
agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
{code}

It is preferable that the setting be of the short form like the following:
{code}
agent.channels.jdbcchannel.maximum.capacity = 1000
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249235#comment-13249235 ] 

jiraposter@reviews.apache.org commented on FLUME-1107:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4677/#review6768
-----------------------------------------------------------



/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
<https://reviews.apache.org/r/4677/#comment14920>

    for readability:
    SYSPRO=>SYSPROP
    (here and in all referenced locations)



/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
<https://reviews.apache.org/r/4677/#comment14924>

    SYSPRO=>SYSPROP



/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
<https://reviews.apache.org/r/4677/#comment14921>

    For readability:
    PROPERTIES=>PROPS
    (here and all referring locations)



/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
<https://reviews.apache.org/r/4677/#comment14925>

    PROPERTIES=>PROPS



/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
<https://reviews.apache.org/r/4677/#comment14922>

    For readability:
    CONNECTION=>CONNECTIONS
    ...here and in all referring locations



/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
<https://reviews.apache.org/r/4677/#comment14923>

    CONNECTION=>CONNECTIONS



/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
<https://reviews.apache.org/r/4677/#comment14927>

    Long=>long
    new form => new short form



/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
<https://reviews.apache.org/r/4677/#comment14928>

    @param defaultValue default value, null if no default


- Will


On 2012-04-07 08:32:03, Arvind Prabhakar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4677/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-07 08:32:03)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.
bq.  
bq.  
bq.  This addresses bug FLUME-1107.
bq.      https://issues.apache.org/jira/browse/FLUME-1107
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 
bq.    /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 
bq.  
bq.  Diff: https://reviews.apache.org/r/4677/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. 
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Arvind
bq.  
bq.


                
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
>                 Key: FLUME-1107
>                 URL: https://issues.apache.org/jira/browse/FLUME-1107
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Channel
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1107-1.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 
> For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Posted by "Prasad Mujumdar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prasad Mujumdar updated FLUME-1107:
-----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)
    
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
>                 Key: FLUME-1107
>                 URL: https://issues.apache.org/jira/browse/FLUME-1107
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Channel
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1107-1.patch, FLUME-1107-2.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 
> For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249236#comment-13249236 ] 

jiraposter@reviews.apache.org commented on FLUME-1107:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4677/#review6769
-----------------------------------------------------------

Ship it!


Other than the nits described, lgtm!

- Will


On 2012-04-07 08:32:03, Arvind Prabhakar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4677/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-07 08:32:03)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.
bq.  
bq.  
bq.  This addresses bug FLUME-1107.
bq.      https://issues.apache.org/jira/browse/FLUME-1107
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 
bq.    /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 
bq.  
bq.  Diff: https://reviews.apache.org/r/4677/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. 
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Arvind
bq.  
bq.


                
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
>                 Key: FLUME-1107
>                 URL: https://issues.apache.org/jira/browse/FLUME-1107
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Channel
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1107-1.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 
> For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250241#comment-13250241 ] 

Hudson commented on FLUME-1107:
-------------------------------

Integrated in flume-trunk #165 (See [https://builds.apache.org/job/flume-trunk/165/])
    FLUME-1107: Configuration keys for JDBC channel contain redundant prefix.
(Arvind Prabhakar via Prasad Mujumdar) (Revision 1311483)

     Result = SUCCESS
prasadm : http://svn.apache.org/viewvc/?view=rev&rev=1311483
Files : 
* /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
* /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
* /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java

                
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
>                 Key: FLUME-1107
>                 URL: https://issues.apache.org/jira/browse/FLUME-1107
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Channel
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1107-1.patch, FLUME-1107-2.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 
> For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249325#comment-13249325 ] 

jiraposter@reviews.apache.org commented on FLUME-1107:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4677/#review6776
-----------------------------------------------------------

Ship it!


- Will


On 2012-04-07 20:01:51, Arvind Prabhakar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4677/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-07 20:01:51)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.
bq.  
bq.  
bq.  This addresses bug FLUME-1107.
bq.      https://issues.apache.org/jira/browse/FLUME-1107
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 
bq.    /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 
bq.    /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 1310683 
bq.  
bq.  Diff: https://reviews.apache.org/r/4677/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. 
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Arvind
bq.  
bq.


                
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
>                 Key: FLUME-1107
>                 URL: https://issues.apache.org/jira/browse/FLUME-1107
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Channel
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1107-1.patch, FLUME-1107-2.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 
> For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249321#comment-13249321 ] 

jiraposter@reviews.apache.org commented on FLUME-1107:
------------------------------------------------------



bq.  On 2012-04-07 12:35:09, Will McQueen wrote:
bq.  > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 27
bq.  > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line27>
bq.  >
bq.  >     for readability:
bq.  >     SYSPRO=>SYSPROP
bq.  >     (here and in all referenced locations)

done.


bq.  On 2012-04-07 12:35:09, Will McQueen wrote:
bq.  > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 33
bq.  > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line33>
bq.  >
bq.  >     SYSPRO=>SYSPROP

done.


bq.  On 2012-04-07 12:35:09, Will McQueen wrote:
bq.  > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 69
bq.  > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line69>
bq.  >
bq.  >     For readability:
bq.  >     PROPERTIES=>PROPS
bq.  >     (here and all referring locations)

done.


bq.  On 2012-04-07 12:35:09, Will McQueen wrote:
bq.  > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 75
bq.  > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line75>
bq.  >
bq.  >     PROPERTIES=>PROPS

done.


bq.  On 2012-04-07 12:35:09, Will McQueen wrote:
bq.  > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 121
bq.  > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line121>
bq.  >
bq.  >     For readability:
bq.  >     CONNECTION=>CONNECTIONS
bq.  >     ...here and in all referring locations

done.


bq.  On 2012-04-07 12:35:09, Will McQueen wrote:
bq.  > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 126
bq.  > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line126>
bq.  >
bq.  >     CONNECTION=>CONNECTIONS

done.


bq.  On 2012-04-07 12:35:09, Will McQueen wrote:
bq.  > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java, line 542
bq.  > <https://reviews.apache.org/r/4677/diff/1/?file=100846#file100846line542>
bq.  >
bq.  >     Long=>long
bq.  >     new form => new short form

done.


bq.  On 2012-04-07 12:35:09, Will McQueen wrote:
bq.  > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java, line 550
bq.  > <https://reviews.apache.org/r/4677/diff/1/?file=100846#file100846line550>
bq.  >
bq.  >     @param defaultValue default value, null if no default

done.


- Arvind


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4677/#review6768
-----------------------------------------------------------


On 2012-04-07 08:32:03, Arvind Prabhakar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4677/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-07 08:32:03)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.
bq.  
bq.  
bq.  This addresses bug FLUME-1107.
bq.      https://issues.apache.org/jira/browse/FLUME-1107
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 
bq.    /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 
bq.  
bq.  Diff: https://reviews.apache.org/r/4677/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. 
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Arvind
bq.  
bq.


                
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
>                 Key: FLUME-1107
>                 URL: https://issues.apache.org/jira/browse/FLUME-1107
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Channel
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1107-1.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 
> For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arvind Prabhakar updated FLUME-1107:
------------------------------------

    Attachment: FLUME-1107-2.patch
    
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
>                 Key: FLUME-1107
>                 URL: https://issues.apache.org/jira/browse/FLUME-1107
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Channel
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1107-1.patch, FLUME-1107-2.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 
> For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arvind Prabhakar updated FLUME-1107:
------------------------------------

    Attachment: FLUME-1107-1.patch
    
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
>                 Key: FLUME-1107
>                 URL: https://issues.apache.org/jira/browse/FLUME-1107
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Channel
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1107-1.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 
> For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249212#comment-13249212 ] 

jiraposter@reviews.apache.org commented on FLUME-1107:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4677/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.


This addresses bug FLUME-1107.
    https://issues.apache.org/jira/browse/FLUME-1107


Diffs
-----

  /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 
  /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 

Diff: https://reviews.apache.org/r/4677/diff


Testing
-------

Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. 


Thanks,

Arvind


                
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
>                 Key: FLUME-1107
>                 URL: https://issues.apache.org/jira/browse/FLUME-1107
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Channel
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>
> The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 
> For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250210#comment-13250210 ] 

jiraposter@reviews.apache.org commented on FLUME-1107:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4677/#review6804
-----------------------------------------------------------

Ship it!


lgtm

- Prasad


On 2012-04-07 20:01:51, Arvind Prabhakar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4677/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-07 20:01:51)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.
bq.  
bq.  
bq.  This addresses bug FLUME-1107.
bq.      https://issues.apache.org/jira/browse/FLUME-1107
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 
bq.    /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 
bq.    /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 1310683 
bq.  
bq.  Diff: https://reviews.apache.org/r/4677/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. 
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Arvind
bq.  
bq.


                
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
>                 Key: FLUME-1107
>                 URL: https://issues.apache.org/jira/browse/FLUME-1107
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Channel
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1107-1.patch, FLUME-1107-2.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 
> For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249322#comment-13249322 ] 

jiraposter@reviews.apache.org commented on FLUME-1107:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4677/
-----------------------------------------------------------

(Updated 2012-04-07 20:01:51.619038)


Review request for Flume.


Changes
-------

Thanks for the review Will. I have incorporated your suggestions.


Summary
-------

Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.


This addresses bug FLUME-1107.
    https://issues.apache.org/jira/browse/FLUME-1107


Diffs (updated)
-----

  /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 
  /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 
  /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 1310683 

Diff: https://reviews.apache.org/r/4677/diff


Testing
-------

Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. 


Thanks,

Arvind


                
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
>                 Key: FLUME-1107
>                 URL: https://issues.apache.org/jira/browse/FLUME-1107
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Channel
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1107-1.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 
> For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1107) Configuration keys for JDBC channel contain redundant prefix.

Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arvind Prabhakar updated FLUME-1107:
------------------------------------

    Fix Version/s: v1.2.0
           Status: Patch Available  (was: Open)
    
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
>                 Key: FLUME-1107
>                 URL: https://issues.apache.org/jira/browse/FLUME-1107
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Channel
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1107-1.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system. 
> For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira