[jira] [Commented] (AIRFLOW-3649) Feature to add extra labels to kubernetes worker pods

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736807#comment-16736807 ] 

ASF GitHub Bot commented on AIRFLOW-3649:
-----------------------------------------

wyndhblb commented on pull request #4459: [AIRFLOW-3649] Feature to add extra labels to kubernetes worker pods
URL: https://github.com/apache/airflow/pull/4459
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   This pr is meant to add the ability to attached a static set of extra labels to worker pods for resource, metrics, and other use tracking.
   
   ### Tests
   
   - [ X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Feature to add extra labels to kubernetes worker pods
> -----------------------------------------------------
>
>                 Key: AIRFLOW-3649
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3649
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: kubernetes
>    Affects Versions: 1.10.1
>            Reporter: Bo Blanton
>            Priority: Major
>
> For many systems and metrics emitters in k8, the pod labels are used to tag these metrics and other resource utilization metrics.
> Since airflow adds a fixed set of "reserved" labels for its own identification of worker nodes, we wish to add some static labels for just these purposes.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)