[jira] Commented: (TOMAHAWK-1365) Input field id in error messages is not properly replaced with label text

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/TOMAHAWK-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645144#action_12645144 ] 

Leonardo Uribe commented on TOMAHAWK-1365:
------------------------------------------

Hi

I have tested exhaustively this issue and the issue is only present when jsf 1.2 version is present
(both myfaces and mojarra).

The solution is do what it is supposed to do when specific jsf 1.2 issues are found: copy the 
file on tomahawk12 and change it. A change on 1.1 branch is not preffered, to maintain backward compatibility,
but I have to note that the patch works on both branches. After all, tomahawk12 is build against jsf 1.2 related
artifacts (myfaces core 1.2.x, myfaces shared 3.0.x).

The tested environments were:

myfaces 1.2.5 and tomahawk12 1.1.8-SNAPSHOT (with patch) works
myfaces 1.1.6 and tomahawk 1.1.8-SNAPSHOT (without patch) works 
myfaces 1.2.5 and tomahawk 1.1.8-SNAPSHOT do not works (but on 1.2.x versions tomahawk12 should be used instead)

So If no objections I'll commit the solution on tomahawk 1.2 branch 

> Input field id in error messages is not properly replaced with label text
> -------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1365
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1365
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Message(s)
>    Affects Versions: 1.1.8-SNAPSHOT
>            Reporter: Val Blant
>         Attachments: TOMAHAWK-1365.patch
>
>
> When we have a label associated with an input field via the 'for' attribute on the label, the client id substitution is not properly handled by org.apache.myfaces.renderkit.html.ext.HtmlMessageRenderer.findInputId().
> The problem is that when an error message is put together by a converter, javax.faces.convert._MessageUtils.getLabel() places the full clientId of the input component into the message text, whereas HtmlMessageRenderer replaces only the id with the label text.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.